Repository navigation
Commit 761cb4c
committed
fix(cursor): keep failure guidance for a failed exec wrapper
Follow-up review finding (CodeRabbit) on 60537f0, and a regression I introduced
in the previous commit rather than a pre-existing one.
Routing Cursor's Codex-exec branch through `isEmptyOrFailedExecWrapper` restored
the old matching, but the branch still returned `EMPTY_EXEC_OUTPUT_MESSAGE`
unconditionally. A `Script failed` wrapper therefore reported that execution
succeeded with empty output, erasing the only failure signal — the same defect
just fixed on the Kiro path, reintroduced one layer up. It classifies the text by
wrapper now; Cursor's `isError` policy is untouched and still owned by the
Computer Use branch above it.
The re-posted Codex P2 about `completionMode` staying `required` was checked
against current code and is already addressed at `kiro.ts:513-515`: a trailing
delivered answer resolves the mode to `disabled`, so the completion tool and its
instructions are never advertised and the `needsFallback` retry path cannot be
entered. The comment it cites sits at the acknowledgement, which is the second
half of that fix.
Verification: `bun x tsc --noEmit` clean; 204 tests pass across the same five
suites. The new Cursor assertion was driven red by reverting the fix.1 parent 60537f0 commit 761cb4c
2 files changed
Lines changed: 15 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
95 | 96 | | |
96 | 97 | | |
97 | 98 | | |
98 | | - | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
99 | 103 | | |
100 | 104 | | |
101 | 105 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
32 | 42 | | |
33 | 43 | | |
34 | 44 | | |
| |||
0 commit comments