Repository navigation
Commit 75a1b31
committed
fix(test): sanitize both shim recursion-guard variables
The autostart shim test deleted OCX_SHIM_ACTIVE_PID from the child environment
but inherited OCX_SHIM_ACTIVE_DEPTH from the parent. A developer running the
suite from a shell that was itself launched through an installed Codex shim
carries DEPTH=1, so the outer shim started at depth 1 rather than 0, the child
re-entry landed on depth 2, and the guard exited 126 with its launcher-loop
message. The shim was behaving exactly as designed; the test was starting from
a slate it believed was clean.
CI never sees this because CI has no shimmed ancestor, which is precisely what
made it look like a machine quirk.
I had recorded the cause as the sandbox blocking execution from a temp path.
That was wrong - a chmod 755 script in mktemp -d runs fine here and /var/folders
is not mounted noexec - and a reviewer traced the real mechanism. The devlog now
carries the correction, because a plausible-sounding wrong explanation in a
durable record is worse than no explanation.1 parent 4254fce commit 75a1b31
2 files changed
Lines changed: 27 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
242 | 242 | | |
243 | 243 | | |
244 | 244 | | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | | - | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1043 | 1043 | | |
1044 | 1044 | | |
1045 | 1045 | | |
| 1046 | + | |
| 1047 | + | |
| 1048 | + | |
| 1049 | + | |
| 1050 | + | |
| 1051 | + | |
1046 | 1052 | | |
| 1053 | + | |
1047 | 1054 | | |
1048 | 1055 | | |
1049 | 1056 | | |
| |||
0 commit comments