Repository navigation
Commit 75251bb
committed
test(service): pin the file mode on POSIX only, not on Windows
The Windows CI shard reported these three as failures: Bun on Windows returns
0666 from statSync for an ordinary file no matter what mode the write asked
for, because Windows does not implement POSIX permission bits at all. The
assertion was testing the emulation layer, not the security property.
The real boundary on Windows is the NTFS ACL, which hardenSecretPath applies
and which the credential-detection tests already cover — those decide whether
that ACL is required or best-effort, which is the question that actually
matters there.
So these three skip on win32 and keep asserting the octal everywhere the octal
means something.
Refs #2107
Worth being precise about what this does and does not fix: three of the 25
Windows shard-4 failures were mine, and they are gone. The other 22 are not —
Log Guard, WP13 composed toggle, /api/keys, and the anthropic 413 retry were
already failing on run 32147924436 (e446607, 2026-08-18), before any of this
work landed, and none of them touch files in this range.1 parent 15527f8 commit 75251bb
1 file changed
Lines changed: 11 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2178 | 2178 | | |
2179 | 2179 | | |
2180 | 2180 | | |
2181 | | - | |
| 2181 | + | |
| 2182 | + | |
| 2183 | + | |
| 2184 | + | |
| 2185 | + | |
| 2186 | + | |
| 2187 | + | |
| 2188 | + | |
| 2189 | + | |
2182 | 2190 | | |
2183 | 2191 | | |
2184 | 2192 | | |
| |||
2192 | 2200 | | |
2193 | 2201 | | |
2194 | 2202 | | |
2195 | | - | |
| 2203 | + | |
2196 | 2204 | | |
2197 | 2205 | | |
2198 | 2206 | | |
| |||
2208 | 2216 | | |
2209 | 2217 | | |
2210 | 2218 | | |
2211 | | - | |
| 2219 | + | |
2212 | 2220 | | |
2213 | 2221 | | |
2214 | 2222 | | |
| |||
0 commit comments