Repository navigation
Commit 6f8b1d6
committed
fix(config): honor registry wire defaults and own-property lookup for hosted-tool preferences
Two defects the plan audit found in this change, both reproduced before
fixing.
Validation disagreed with routing. `modelPreferHostedTools` resolved the
effective wire from `registry.adapter` and an explicit `modelAdapters`
entry, then stopped. At request time `resolveModelAdapter()` consults the
registry's per-model `modelWireDefaults` before falling back to the
provider-wide adapter. DeepSeek routes `deepseek-v4-flash` over native
Responses for a Responses inbound while its provider-wide wire stays
openai-chat, so a valid preference for that model was rejected at config
load with "requires the openai-responses wire" — a config the runtime would
have honored. The validator now walks the same order.
Inherited keys threw before dispatch. `provider.modelPreferHostedTools?.
[modelId]` walks the prototype chain, so a routed model id of `constructor`
or `toString` resolved to a function and threw `TypeError: ... .includes is
not a function` inside `preferConfiguredHostedTools`, failing the request.
Lookup is now own-property only and requires an array.
Both regressions were driven red first: the DeepSeek case produced the exact
rejection above, and the inherited-key case produced the exact TypeError.
247 tests pass across the four affected files, typecheck clean.1 parent b3329ed commit 6f8b1d6
4 files changed
Lines changed: 81 additions & 7 deletions
File tree
- src
- adapters
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
651 | 651 | | |
652 | 652 | | |
653 | 653 | | |
654 | | - | |
655 | | - | |
| 654 | + | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
656 | 664 | | |
657 | 665 | | |
658 | 666 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| |||
712 | 712 | | |
713 | 713 | | |
714 | 714 | | |
715 | | - | |
| 715 | + | |
716 | 716 | | |
717 | 717 | | |
718 | 718 | | |
| |||
732 | 732 | | |
733 | 733 | | |
734 | 734 | | |
735 | | - | |
736 | | - | |
737 | | - | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
738 | 759 | | |
739 | 760 | | |
740 | 761 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1031 | 1031 | | |
1032 | 1032 | | |
1033 | 1033 | | |
| 1034 | + | |
| 1035 | + | |
| 1036 | + | |
| 1037 | + | |
| 1038 | + | |
| 1039 | + | |
| 1040 | + | |
| 1041 | + | |
| 1042 | + | |
| 1043 | + | |
| 1044 | + | |
| 1045 | + | |
| 1046 | + | |
| 1047 | + | |
| 1048 | + | |
| 1049 | + | |
| 1050 | + | |
| 1051 | + | |
| 1052 | + | |
1034 | 1053 | | |
1035 | 1054 | | |
1036 | 1055 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1121 | 1121 | | |
1122 | 1122 | | |
1123 | 1123 | | |
| 1124 | + | |
| 1125 | + | |
| 1126 | + | |
| 1127 | + | |
| 1128 | + | |
| 1129 | + | |
| 1130 | + | |
| 1131 | + | |
| 1132 | + | |
| 1133 | + | |
| 1134 | + | |
| 1135 | + | |
| 1136 | + | |
| 1137 | + | |
| 1138 | + | |
| 1139 | + | |
| 1140 | + | |
| 1141 | + | |
| 1142 | + | |
| 1143 | + | |
| 1144 | + | |
| 1145 | + | |
| 1146 | + | |
| 1147 | + | |
| 1148 | + | |
| 1149 | + | |
1124 | 1150 | | |
1125 | 1151 | | |
1126 | 1152 | | |
| |||
0 commit comments