You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 6bede37
Browse filesBrowse the repository at this point in the historyBrowse files
fix(responses): make namespace dedup order-independent and restore custom calls by wire identity
Review found two defects in the flattening layer; both are fixed here.
Deduplication depended on declaration order. A bare declaration and a `functions`
child of the same name are one logical tool, but which one owned the wire name —
and therefore which one was emitted — followed whichever container the rewrite
reached first. The plan now records the bare wire names from the complete catalog
and the bare declaration always wins, so the same catalog flattens identically
whichever container declares it.
Custom-call restoration used the wrong coordinate. A custom tool inside a
non-`functions` namespace is lowered twice on the way out (custom to function,
then renamed to `<ns>__<name>`), while on the way back namespace restore runs
first and replaces the wire name with the bare one. Custom restore then matched
that bare name and could convert an unrelated same-named function call, sending
Codex a `custom_tool_call` with the wrong payload shape.
Converted custom tools are now tracked by their final upstream wire name, and
restoration reconstructs that identity from the `{namespace, name}` an earlier
rewrite restored. A namespaced custom and a namespaced function sharing a child
name now round-trip to their own item types, on both the JSON and SSE paths.
Co-Authored-By: Claude Fable 5 <[email protected]>
0 commit comments