Repository navigation
Commit 68fe94e
committed
fix(gui): say why the bulk loop is serial, where the linter will read it
React Doctor blocked the push on `async-await-in-loop`, suggesting
`Promise.all`. Taking that suggestion would corrupt state: the server's
single-flight guard is keyed per client, so it does not serialize across
different ones, and writeRecord/deleteRecord read-modify-write a shared
records.json with no lock. Six concurrent disables interleave those writes and
drop an ownership record — the proof that a block is ours — after which the
next disable refuses as `unowned-key` and the block is stranded in the user's
config with nothing claiming it. Six loopback requests are cheap; a lost
ownership record is not.
Suppressed with the tool's own inline directive on the single line, with the
reasoning in a block comment above it rather than in the config, so the next
person who reads this loop learns why before they try to speed it up. Verified
narrow: --no-respect-inline-disables still reports exactly this one finding.1 parent 8bf7c50 commit 68fe94e
1 file changed
Lines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
103 | 116 | | |
104 | 117 | | |
| 118 | + | |
105 | 119 | | |
106 | 120 | | |
107 | 121 | | |
| |||
0 commit comments