Repository navigation
Commit 68147c7
committed
fix(models): enforce ladder invariants and constrain Pi effort levels
Addresses the lens review of the custom-model reasoning feature:
- PUT /api/custom-models now mirrors the POST invariant: a stored default
effort is dropped whenever the final ladder no longer contains it, so a
ladder shrink/clear (e.g. the GUI toggle-off path, which sends only
reasoningEfforts) can no longer leave a stale default that re-applies
itself onto the inherited ladder in the generated catalog (#962).
- The Pi export constrains pi's own level scale with a thinkingLevelMap:
ladder members map to themselves, everything else (incl. minimal) is
hidden. Custom-row ladders are advertisement-only — the wire clamp in
mapReasoningEffort reads provider config, not customModels — so without
the map pi could offer (and send) levels the ladder does not contain.
- Ladders are canonicalized into Codex order (low..ultra) at API and CLI
ingress so a caller-chosen order cannot leak into supported_reasoning_levels.
- GUI: enabling "Override reasoning effort" pre-checks the full ladder,
so an accidental save with zero steps can no longer silently disable
reasoning for the model (#883 semantics stays reachable deliberately).
- CLI: ocx models add accepts "-" for both reasoning flags (inherit) and
rejects an empty string; the parsing/validation is extracted into an
exported parseReasoningArgs and covered by tests together with the edit
flag mapping.
- Removes the now-dead defaultReasoningEffort exposure from /api/models
custom rows and the GUI ModelRow (CLI/API keep it on OcxCustomModel).1 parent e6a7113 commit 68147c7
19 files changed
Lines changed: 295 additions & 48 deletions
File tree
- docs-site/src/content/docs/guides
- gui/src
- i18n
- pages
- src
- clients
- cli
- server/management
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
114 | | - | |
115 | | - | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
116 | 117 | | |
117 | 118 | | |
118 | 119 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
539 | 539 | | |
540 | 540 | | |
541 | 541 | | |
542 | | - | |
543 | | - | |
| 542 | + | |
| 543 | + | |
544 | 544 | | |
545 | 545 | | |
546 | 546 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
564 | 564 | | |
565 | 565 | | |
566 | 566 | | |
567 | | - | |
568 | | - | |
| 567 | + | |
| 568 | + | |
569 | 569 | | |
570 | 570 | | |
571 | 571 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1957 | 1957 | | |
1958 | 1958 | | |
1959 | 1959 | | |
1960 | | - | |
1961 | | - | |
| 1960 | + | |
| 1961 | + | |
1962 | 1962 | | |
1963 | 1963 | | |
1964 | 1964 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
550 | 550 | | |
551 | 551 | | |
552 | 552 | | |
553 | | - | |
554 | | - | |
| 553 | + | |
| 554 | + | |
555 | 555 | | |
556 | 556 | | |
557 | 557 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
552 | 552 | | |
553 | 553 | | |
554 | 554 | | |
555 | | - | |
556 | | - | |
| 555 | + | |
| 556 | + | |
557 | 557 | | |
558 | 558 | | |
559 | 559 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
555 | 555 | | |
556 | 556 | | |
557 | 557 | | |
558 | | - | |
559 | | - | |
| 558 | + | |
| 559 | + | |
560 | 560 | | |
561 | 561 | | |
562 | 562 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
420 | 420 | | |
421 | 421 | | |
422 | 422 | | |
423 | | - | |
424 | | - | |
| 423 | + | |
| 424 | + | |
425 | 425 | | |
426 | 426 | | |
427 | 427 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
547 | 547 | | |
548 | 548 | | |
549 | 549 | | |
550 | | - | |
551 | | - | |
| 550 | + | |
| 551 | + | |
552 | 552 | | |
553 | 553 | | |
554 | 554 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1614 | 1614 | | |
1615 | 1615 | | |
1616 | 1616 | | |
1617 | | - | |
| 1617 | + | |
| 1618 | + | |
| 1619 | + | |
| 1620 | + | |
| 1621 | + | |
| 1622 | + | |
| 1623 | + | |
1618 | 1624 | | |
1619 | 1625 | | |
1620 | 1626 | | |
| |||
0 commit comments