Skip to content

Commit 68147c7

Browse files
committed
fix(models): enforce ladder invariants and constrain Pi effort levels
Addresses the lens review of the custom-model reasoning feature: - PUT /api/custom-models now mirrors the POST invariant: a stored default effort is dropped whenever the final ladder no longer contains it, so a ladder shrink/clear (e.g. the GUI toggle-off path, which sends only reasoningEfforts) can no longer leave a stale default that re-applies itself onto the inherited ladder in the generated catalog (#962). - The Pi export constrains pi's own level scale with a thinkingLevelMap: ladder members map to themselves, everything else (incl. minimal) is hidden. Custom-row ladders are advertisement-only — the wire clamp in mapReasoningEffort reads provider config, not customModels — so without the map pi could offer (and send) levels the ladder does not contain. - Ladders are canonicalized into Codex order (low..ultra) at API and CLI ingress so a caller-chosen order cannot leak into supported_reasoning_levels. - GUI: enabling "Override reasoning effort" pre-checks the full ladder, so an accidental save with zero steps can no longer silently disable reasoning for the model (#883 semantics stays reachable deliberately). - CLI: ocx models add accepts "-" for both reasoning flags (inherit) and rejects an empty string; the parsing/validation is extracted into an exported parseReasoningArgs and covered by tests together with the edit flag mapping. - Removes the now-dead defaultReasoningEffort exposure from /api/models custom rows and the GUI ModelRow (CLI/API keep it on OcxCustomModel).
1 parent e6a7113 commit 68147c7

19 files changed

Lines changed: 295 additions & 48 deletions

File tree

‎docs-site/src/content/docs/guides/pi.md‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,9 @@ catalog's ladder is the proxy's own statement about whether a model accepts reas
111111
(adapters honor `reasoning_effort`), an export row with a **non-empty** ladder now emits
112112
`"reasoning": true`, and a row without one (or with an explicitly empty ladder) stays
113113
reasoning-free. Pi then offers its effort control for exactly the models opencodex will accept it
114-
on. If you need Pi-specific effort values — for example clamping `xhigh`/`max` away — add a
115-
hand-written `thinkingLevelMap` to the model entry as documented by Pi.
114+
on. The export also emits a `thinkingLevelMap` that hides every pi level outside the declared
115+
ladder (`null`), so pi never offers — and never sends — an effort the ladder does not contain.
116+
If you need a different mapping, hand-edit `thinkingLevelMap` afterwards as documented by Pi.
116117

117118
## Schema status
118119

‎gui/src/i18n/de.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -539,8 +539,8 @@ export const de: Record<TKey, string> = {
539539
"models.customFieldDisplayNamePlaceholder": "z. B. Qwen 4 Max Preview",
540540
"models.customFieldContext": "Kontextfenster",
541541
"models.customFieldModalities": "Eingabemodalitäten",
542-
"models.customFieldReasoning": "Unterstützte Reasoning Stufen",
543-
"models.customFieldReasoningOverride": "Reasoning-Stufen überschreiben",
542+
"models.customFieldReasoning": "Reasoning-Aufwand",
543+
"models.customFieldReasoningOverride": "Reasoning-Aufwand überschreiben",
544544
"models.tipProvider": "Anbieter",
545545
"models.tipContext": "Kontext",
546546
"models.tipModalities": "Modalitäten",

‎gui/src/i18n/en.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -564,8 +564,8 @@ export const en = {
564564
"models.customFieldDisplayNamePlaceholder": "e.g. Qwen 4 Max Preview",
565565
"models.customFieldContext": "Context window",
566566
"models.customFieldModalities": "Input modalities",
567-
"models.customFieldReasoning": "Supported reasoning steps",
568-
"models.customFieldReasoningOverride": "Override reasoning steps",
567+
"models.customFieldReasoning": "Reasoning effort",
568+
"models.customFieldReasoningOverride": "Override reasoning effort",
569569
"models.tipProvider": "Provider",
570570
"models.tipContext": "Context",
571571
"models.tipModalities": "Modalities",

‎gui/src/i18n/ja.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1957,8 +1957,8 @@ export const ja: Record<TKey, string> = {
19571957
"models.customFieldDisplayNamePlaceholder": "e.g. Qwen 4 Max Preview",
19581958
"models.customFieldContext": "Context window",
19591959
"models.customFieldModalities": "Input modalities",
1960-
"models.customFieldReasoning": "サポートされる推論ステップ",
1961-
"models.customFieldReasoningOverride": "推論ステップを上書き",
1960+
"models.customFieldReasoning": "推論努力",
1961+
"models.customFieldReasoningOverride": "推論努力を上書き",
19621962
"models.tipProvider": "Provider",
19631963
"models.tipContext": "Context",
19641964
"models.tipModalities": "Modalities",

‎gui/src/i18n/ko.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -550,8 +550,8 @@ export const ko: Record<TKey, string> = {
550550
"models.customFieldDisplayNamePlaceholder": "예: Qwen 4 Max Preview",
551551
"models.customFieldContext": "컨텍스트 윈도우",
552552
"models.customFieldModalities": "입력 모달리티",
553-
"models.customFieldReasoning": "지원 추론 단계",
554-
"models.customFieldReasoningOverride": "추론 단계 재정의",
553+
"models.customFieldReasoning": "추론 노력",
554+
"models.customFieldReasoningOverride": "추론 노력 재정의",
555555
"models.tipProvider": "프로바이더",
556556
"models.tipContext": "컨텍스트",
557557
"models.tipModalities": "모달리티",

‎gui/src/i18n/ru.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -552,8 +552,8 @@ export const ru: Record<TKey, string> = {
552552
"models.customFieldDisplayNamePlaceholder": "например, Qwen 4 Max Preview",
553553
"models.customFieldContext": "Контекстное окно",
554554
"models.customFieldModalities": "Входные модальности",
555-
"models.customFieldReasoning": "Поддерживаемые ступени рассуждений",
556-
"models.customFieldReasoningOverride": "Переопределить ступени рассуждений",
555+
"models.customFieldReasoning": "Уровень рассуждений",
556+
"models.customFieldReasoningOverride": "Переопределить уровень рассуждений",
557557
"models.tipProvider": "Провайдер",
558558
"models.tipContext": "Контекст",
559559
"models.tipModalities": "Модальности",

‎gui/src/i18n/tr.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -555,8 +555,8 @@ export const tr: Record<TKey, string> = {
555555
"models.customFieldDisplayNamePlaceholder": "örn. Qwen 4 Max Preview",
556556
"models.customFieldContext": "Bağlam penceresi",
557557
"models.customFieldModalities": "Girdi türleri",
558-
"models.customFieldReasoning": "Desteklenen akıl yürütme adımları",
559-
"models.customFieldReasoningOverride": "Akıl yürütme adımlarını geçersiz kıl",
558+
"models.customFieldReasoning": "Akıl yürütme çabası",
559+
"models.customFieldReasoningOverride": "Akıl yürütme çabasını geçersiz kıl",
560560
"models.tipProvider": "Sağlayıcı",
561561
"models.tipContext": "Bağlam",
562562
"models.tipModalities": "Girdi Türleri",

‎gui/src/i18n/zh-TW.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -420,8 +420,8 @@ export const zhTW: Record<TKey, string> = {
420420
"models.customFieldDisplayNamePlaceholder": "例如 Qwen 4 Max Preview",
421421
"models.customFieldContext": "上下文視窗",
422422
"models.customFieldModalities": "輸入模態",
423-
"models.customFieldReasoning": "支援的推理步驟",
424-
"models.customFieldReasoningOverride": "覆寫推理步驟",
423+
"models.customFieldReasoning": "推理強度",
424+
"models.customFieldReasoningOverride": "覆寫推理強度",
425425
"models.tipProvider": "供應商",
426426
"models.tipContext": "上下文",
427427
"models.tipModalities": "模態",

‎gui/src/i18n/zh.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -547,8 +547,8 @@ export const zh: Record<TKey, string> = {
547547
"models.customFieldDisplayNamePlaceholder": "例如 Qwen 4 Max Preview",
548548
"models.customFieldContext": "上下文窗口",
549549
"models.customFieldModalities": "输入模态",
550-
"models.customFieldReasoning": "支持的推理步骤",
551-
"models.customFieldReasoningOverride": "覆盖推理步骤",
550+
"models.customFieldReasoning": "推理强度",
551+
"models.customFieldReasoningOverride": "覆盖推理强度",
552552
"models.tipProvider": "提供方",
553553
"models.tipContext": "上下文",
554554
"models.tipModalities": "模态",

‎gui/src/pages/Models.tsx‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1614,7 +1614,13 @@ export default function Models({ apiBase }: { apiBase: string }) {
16141614
<input
16151615
type="checkbox"
16161616
checked={customFormReasoning}
1617-
onChange={e => setCustomFormReasoning(e.target.checked)}
1617+
onChange={e => {
1618+
setCustomFormReasoning(e.target.checked);
1619+
// Default to the full ladder: the common intent is "allow every known
1620+
// step". An explicit no-reasoning override (empty ladder) then requires
1621+
// deliberately unchecking all of them instead of being an accident.
1622+
if (e.target.checked) setCustomFormReasoningEfforts([...REASONING_EFFORT_LEVELS]);
1623+
}}
16181624
disabled={customSaving}
16191625
/>
16201626
<span className="text-control">{t("models.customFieldReasoningOverride")}</span>

0 commit comments

Comments
 (0)