Repository navigation
Commit 61a1eda
jun
fix(windows): degrade an invalidated in-flight catalog observation to unknown
The generation check suppressed the cache write but still returned the
pre-write status to the request already awaiting it. That request then saw
`fresh`, which is the one state authorizing positive model guidance
(collaboration.ts returns null for stale/unknown), so it would advertise the
newly written disk catalog to an app-server whose in-memory copy the write had
just made stale.
That trades the hang this change exists to fix for a wrong answer, which is the
worse failure. Return `unknown` when the generation moved: it is what an
invalidated observation actually knows, and the guidance path already treats it
as say-nothing.
The existing regression asserted the old `fresh` result, so it pinned the
defect; it now asserts `unknown`, and a companion test proves the next
post-write observation still reports `fresh` rather than being poisoned.
Both fail when the fix is reverted.1 parent 53ffc9e commit 61a1eda
2 files changed
Lines changed: 58 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
900 | 900 | | |
901 | 901 | | |
902 | 902 | | |
903 | | - | |
904 | | - | |
905 | | - | |
| 903 | + | |
| 904 | + | |
| 905 | + | |
| 906 | + | |
| 907 | + | |
| 908 | + | |
| 909 | + | |
| 910 | + | |
| 911 | + | |
| 912 | + | |
| 913 | + | |
| 914 | + | |
| 915 | + | |
| 916 | + | |
| 917 | + | |
| 918 | + | |
| 919 | + | |
| 920 | + | |
| 921 | + | |
906 | 922 | | |
907 | 923 | | |
908 | 924 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
152 | 152 | | |
153 | 153 | | |
154 | 154 | | |
155 | | - | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
156 | 161 | | |
157 | 162 | | |
158 | 163 | | |
| |||
161 | 166 | | |
162 | 167 | | |
163 | 168 | | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
164 | 202 | | |
165 | 203 | | |
166 | 204 | | |
| |||
0 commit comments