Skip to content

Commit 5d4151e

Browse files
committed
docs(devlog): correct the closeout count and record the red merge
Two corrections from the promotion audit. The closed table listed #1894, #1843 and #1899 as issues. #1899 is a pull request, so two issues closed this campaign, not three - the original phrasing overstated the run. And PR #1921's merge commit carries a failing hosted run. The failure is a wall-clock assertion in request-pacing, the classic flake shape on a loaded macOS runner, and every subsequent run on dev is green including the current head. Not a blocker, but it landed red and the record did not say so. A campaign record that omits the one merge that went in red is not one you can trust later. Also supersedes the no-green-run statement: run 32090176020 on 9eb3a10 is completed/success with every job green.
1 parent c2fa66e commit 5d4151e

1 file changed

Lines changed: 29 additions & 5 deletions

File tree

‎devlog/_plan/260817_wave5_execution/090_wave6_closeout.md‎

Lines changed: 29 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,11 +88,16 @@ Run on the promotion candidate (local `dev`, 6 commits ahead of `origin/dev` at
8888

8989
### What actually closed, under the close-on-dev-merge decision
9090

91-
| Closed | Landed via |
92-
|--------|-----------|
93-
| #1894 | #1739 through PR #1921 |
94-
| #1843 | #1860, already released in v2.24.0 |
95-
| #1899 | superseded by the ordering assertion in PR #1923 |
91+
**Two issues** closed, plus one pull request:
92+
93+
| Closed | Kind | Landed via |
94+
|--------|------|-----------|
95+
| #1894 | issue | #1739 through PR #1921 |
96+
| #1843 | issue | #1860, already released in v2.24.0 |
97+
| #1899 | **pull request** | superseded by the ordering assertion in PR #1923 |
98+
99+
The first version of this table listed all three as issues, which overstated the run.
100+
#1899 is a PR; two issues closed, not three.
96101

97102
Everything else stayed open, and none of it for release-timing reasons — which is the point
98103
worth making about the policy change. It removed a gate that was never what held these back.
@@ -104,3 +109,22 @@ worth making about the policy change. It removed a gate that was never what held
104109
and `aca3c0241` were both cancelled by supersession as later merges landed. The local full
105110
suite above is the evidence that exists; a hosted run on the exact promotion head is the
106111
evidence that does not, and promotion should carry that distinction rather than bury it.
112+
### One merge landed on a red run
113+
114+
PR #1921's merge commit `9dbc5fc42` has a failing hosted run (`32026536154`). The failure is
115+
`provider request pacing queue > spaces concurrent starts in one provider FIFO` in
116+
`tests/request-pacing.test.ts` — a wall-clock assertion, which is the classic flake shape on a
117+
loaded macOS runner. Evidence it is not a live regression: the file passes locally, and every
118+
subsequent hosted run on `dev` is green including the current head.
119+
120+
It is recorded here because it happened, not because it blocks anything. A campaign record that
121+
omits the one merge that landed red is exactly the kind of record you cannot trust later.
122+
123+
### Promotion evidence, updated
124+
125+
The "no completed green run" statement above is **stale and superseded**. Run `32090176020` on
126+
`9eb3a101a` is `completed/success` with every job green — four test shards, macOS, keyring on
127+
all three OSes, npm-global on all three, gates, storage policy, api usage.
128+
129+
So the hosted evidence now exists. Promote the head CI actually evaluated; promoting a local ref
130+
that no run has seen would re-open the exact gap this section was written about.

0 commit comments

Comments
 (0)