Repository navigation
Commit 566a471
committed
test(codex): pin the transport boundary at the adjacent byte
The sizing helper already had unit tests, but nothing proved the real
serialized frame routes correctly one byte on each side of the limit.
That gap matters because the request body is not the frame: `stream` is
deleted and `type` is added before sending, so padding sized against the
body sits eleven bytes away from what is actually transmitted. An
off-by-one would live exactly there and pass every existing test.
These two build padding so the serialized frame is exactly limit-1 and
exactly limit, then assert the whole path: one socket and one send of the
expected byte length under, zero sockets and one SSE call at it. Flipping
the gate from >= to > fails the second one, so it catches a real
off-by-one at the transport level rather than only in the helper.
Two comment corrections while here. The close-code comment claimed the
named 1009 message makes the failure diagnosable from the logs; it does
not. The eager relay turns any stream error into a generic
`upstream_reset` synthetic terminal without feeding it back through the
inspector, so `/api/logs` retains only `streamAborted`. The message
reaches the client and stops there, and the comment now says so rather
than promising observability the code does not deliver.
The margin comment described 64 KiB as absorbing a future append. There
is no append. It is a conservative cushion, and the useful thing to
record is what it actually covers: RFC 6455 framing is 14 bytes at this
payload size — an 8-byte extended length plus a 4-byte client mask — so
even a backend counting frame headers has ~65.5 KiB of room.
Tests: 59 pass, 1 skip across ws-upstream, sse-failed-tail, and
upstream-http-version. tsc --noEmit clean.1 parent f093bf0 commit 566a471
2 files changed
Lines changed: 78 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | | - | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
42 | 45 | | |
43 | 46 | | |
44 | 47 | | |
| |||
122 | 125 | | |
123 | 126 | | |
124 | 127 | | |
125 | | - | |
126 | | - | |
127 | | - | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
128 | 138 | | |
129 | 139 | | |
130 | 140 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
748 | 748 | | |
749 | 749 | | |
750 | 750 | | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
| 781 | + | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
| 788 | + | |
| 789 | + | |
| 790 | + | |
| 791 | + | |
| 792 | + | |
| 793 | + | |
| 794 | + | |
| 795 | + | |
| 796 | + | |
| 797 | + | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
751 | 814 | | |
752 | 815 | | |
753 | 816 | | |
| |||
0 commit comments