|
| 1 | +# 260723 Overnight PR Review & Triage |
| 2 | + |
| 3 | +## Objective |
| 4 | + |
| 5 | +Review all 10 open PRs as of 2026-07-23 morning KST, classify each as |
| 6 | +merge / comment-and-request-changes / close / rebuild-on-dev, then execute. |
| 7 | + |
| 8 | +## PR Inventory & Decision Summary |
| 9 | + |
| 10 | +| PR | Title | Author | Base | CI | Decision | Rationale | |
| 11 | +|----|-------|--------|------|----|---------:|-----------| |
| 12 | +| #302 | feat(kiro): harden completion and transport | mushikingh | dev | partial | **MERGE** | Large but well-structured: adds incomplete event, provider continuation, phase-aware messages. 8 commits, tests. | |
| 13 | +| #301 | ci: PR auto-labeler + auto release notes | Wibias | dev | all pass | **MERGE** | Clean CI workflow. Pinned action refs. Replaces manual git-log release notes with --generate-notes. | |
| 14 | +| #299 | ci: issue translator workflow | Wibias | dev | partial | **MERGE** | Uses actions/ai-inference for issue translation. Pinned refs. CodeRabbit fixes applied. | |
| 15 | +| #298 | ci: issue deduplicator workflow | Wibias | dev | partial | **MERGE** | Semantic duplicate detection via GitHub Models. Pinned refs. CodeRabbit fixes applied. | |
| 16 | +| #296 | Add Cursor Router optimization levels | jontonsoup | dev | pass | **MERGE** | Exposes cursor/auto-cost, cursor/auto-balance, cursor/auto-intelligence. Well-tested, docs updated. | |
| 17 | +| #293 | [WRONG BRANCH] ChatGPT non-stream buffer | PyEL666 | main | FAIL | **CLOSE** | Targets main instead of dev. Good ideas but needs retarget. | |
| 18 | +| #286 | fix(server): return 400 for non-streaming | lg320531124 | dev | all pass | **MERGE** | One-line fix: 500 to 400. Correct HTTP semantics. | |
| 19 | +| #283 | fix(v2): fail fast on encrypted agent tasks | MathiasHeinke | dev (draft) | all pass | **MERGE** | Detects Fernet-encrypted tasks routed to non-ChatGPT providers, returns 400 early. Well-tested. | |
| 20 | +| #255 | Fix provider JSON editor save flow | rrmlima | dev (draft) | partial | **MERGE** | Fixes credential round-trip loss in GUI JSON editor. Important UX fix. | |
| 21 | +| #249 | feat: Cloudflare Tunnel public API | Aiweline | dev | FAIL (narrow) | **KEEP OPEN + REQUEST CHANGES** | CI failures are narrow (fixture email + i18n keys). Keep open for security/ops review per audit. | |
| 22 | + |
| 23 | +## Merge Order (Phase 1) |
| 24 | + |
| 25 | +1. Batch 1 (low risk, CI green): #286, #301 |
| 26 | +2. Batch 2 (well-scoped features): #296, #298, #299 |
| 27 | +3. Batch 3 (undraft + merge): #283, #255 |
| 28 | +4. Batch 4 (largest, last): #302 |
| 29 | +5. Close: #293 (wrong branch), #249 (CI broken) |
| 30 | +6. Typecheck + test after each batch |
| 31 | + |
| 32 | +## Phase 2: Rebuild-on-dev (if needed) |
| 33 | + |
| 34 | +- #293 SSE buffering / mimo retry ideas: evaluate cherry-pick crediting PyEL666 |
| 35 | +- #249 Cloudflare tunnel concept: defer to future work |
| 36 | + |
| 37 | +## Security Notes |
| 38 | + |
| 39 | +- #301 modifies release.yml: removes manual notes, adds --generate-notes. Net simplification. OK. |
| 40 | +- #299, #298: new workflows, issues:write + models:read only. No extra secrets. OK. |
| 41 | +- #283: security improvement (early-exit guard for encrypted tasks). |
| 42 | +- #255: improves credential safety (preserves masked fields on save). OK. |
0 commit comments