Repository navigation
Commit 4f9f728
fix(responses): compare the serving identity on rotation-safe dimensions
The serving-identity record compared `credentialIdentity`, which for OAuth is
`accountId + generation` and therefore changes on every token refresh. Six of the
eight `bindRouteReasoningReplayScope` call sites are key-rotation or OAuth-refresh
rebinds, so an ordinary refresh registered as "the backend changed" and the next
turn on that thread dropped a valid blob. Key-pool providers would have paid that
repeatedly, and silently — nothing errors, the model just loses cached reasoning.
The module already distinguishes the durable dimensions for exactly this reason
(#1926: the rotating generation deliberately does not participate). The serving
record now compares `providerDestinationDurableIdentity` and
`credentialDurableIdentity`, and refuses to record at all when those are missing
rather than falling back to the volatile pair: a missed strip costs one degraded
turn, a spurious strip is a permanent quality regression. The proxy-owned replay
cache keeps its stricter key, which is deliberate.
Also documents two behaviours that would otherwise read as bugs: a combo that
rotates targets between turns legitimately drops blobs while the SSE model-name
rewrite hides the switch from the client, and the image/web-search loops consume
the replay scope without rebinding, which is what stops an internal small-model
call from poisoning the record for the main conversation.
Co-Authored-By: Claude Fable 5 <[email protected]>1 parent c3d62b0 commit 4f9f728
3 files changed
Lines changed: 87 additions & 9 deletions
File tree
- src/responses
- structure
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
94 | 113 | | |
95 | 114 | | |
96 | 115 | | |
| |||
119 | 138 | | |
120 | 139 | | |
121 | 140 | | |
122 | | - | |
123 | | - | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
124 | 145 | | |
125 | 146 | | |
126 | 147 | | |
127 | 148 | | |
128 | 149 | | |
129 | | - | |
| 150 | + | |
130 | 151 | | |
131 | 152 | | |
132 | 153 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
488 | 488 | | |
489 | 489 | | |
490 | 490 | | |
491 | | - | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
492 | 495 | | |
493 | 496 | | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
494 | 509 | | |
495 | 510 | | |
496 | 511 | | |
497 | 512 | | |
498 | | - | |
| 513 | + | |
499 | 514 | | |
500 | 515 | | |
501 | 516 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| 33 | + | |
32 | 34 | | |
33 | 35 | | |
34 | 36 | | |
| |||
70 | 72 | | |
71 | 73 | | |
72 | 74 | | |
73 | | - | |
74 | | - | |
75 | | - | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
76 | 82 | | |
77 | | - | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
78 | 87 | | |
79 | 88 | | |
80 | 89 | | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
81 | 98 | | |
82 | 99 | | |
83 | 100 | | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
84 | 104 | | |
85 | 105 | | |
86 | 106 | | |
| |||
89 | 109 | | |
90 | 110 | | |
91 | 111 | | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
92 | 134 | | |
93 | 135 | | |
94 | 136 | | |
| |||
0 commit comments