Skip to content

Commit 4f746d1

Browse files
authored
Merge pull request #1348 from Wibias/fix/cl-02-closure-final
test(lab): close CL-02 hardening gate
2 parents f197529 + 84941ad commit 4f746d1

3 files changed

Lines changed: 54 additions & 21 deletions

File tree

‎devlog/_plan/260807_compatibility_lab/001_pr_stack_status.md‎

Lines changed: 22 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ independent review, blockers, and whether a later phase is authorized.
2121
|---|---|---|---|---|---|
2222
| CL-00 | `feat/cl-00-compatibility-contracts` | `3ad5bb6bd3f76f6879d84b78ea39edd3e01ec296` | `c014464237fd3c95bda08bc18bfab8ba8f532308` | [#1286](https://github.com/lidge-jun/opencodex/pull/1286) | ACCEPTED AFTER CODERABBIT REMEDIATION (merged to `dev` at `243c3f4905797aa11c62ba933bb03d6d721266fd`) |
2323
| CL-01 | `feat/cl-01-conformance-harness` | `c2113ca47b8a05c5a5f90679e4eaa640ca2c6a66` | `22d608c82d82e2746c0cef9cd761db19a8e465ee` | [#1320](https://github.com/lidge-jun/opencodex/pull/1320) | MERGED TO `dev` at `4bb249b756abd468c675d2d92fffe4da95ad3e2a` |
24-
| CL-02 | `feat/cl-02-evidence-ledger` | `4bb249b756abd468c675d2d92fffe4da95ad3e2a` | NOT RECORDED | [#1333](https://github.com/lidge-jun/opencodex/pull/1333) | MERGED TO `dev` at `025c37916225dd685d9217e5b40190600f06d278`; POST-MERGE HARDENING [#1343](https://github.com/lidge-jun/opencodex/pull/1343) IN PROGRESS |
25-
| CL-03 | — | — | — | — | NOT STARTED |
24+
| CL-02 | `feat/cl-02-evidence-ledger` | `4bb249b756abd468c675d2d92fffe4da95ad3e2a` | NOT RECORDED | [#1333](https://github.com/lidge-jun/opencodex/pull/1333) | MERGED TO `dev` at `025c37916225dd685d9217e5b40190600f06d278`; POST-MERGE HARDENING [#1343](https://github.com/lidge-jun/opencodex/pull/1343) MERGED at `eee2dab4d1bbacefce56057adad51d734f346702`; FINAL CLOSURE GATE [#1348](https://github.com/lidge-jun/opencodex/pull/1348) |
25+
| CL-03 | — | — | — | — | NOT STARTED; AUTHORIZATION ACTIVATES ON #1348 MERGE AFTER GREEN CI/REVIEW |
2626

2727
The CL-01 starting SHA is the exact CL-00 tip recorded when CL-01 began. Its
2828
moving base-ref name is not a substitute for that historical SHA.
@@ -127,21 +127,33 @@ Claims cannot produce `PROBED`/`VERIFIED`.
127127

128128
- **Prior accepted review-fix head:** `cf626d14c823413fbcd6ac2625d1da16bbac714e`
129129
- **Final #1333 source head:** `1eed4ffbc9772c64f4f22e37869ccb0b9efa90e1`
130-
- **Merge commit:** `025c37916225dd685d9217e5b40190600f06d278`
130+
- **#1333 merge commit:** `025c37916225dd685d9217e5b40190600f06d278`
131131
- A final CodeRabbit review batch arrived immediately before the #1333 merge and
132132
identified additional hardening work in ledger replay, artifact publication,
133133
sensitive purge, event privacy admission, contract-artifact error
134134
classification, conformance execution timestamps, and regression coverage.
135135
- **Post-merge hardening branch:** `fix/cl-02-post-merge-hardening`
136-
- **Post-merge hardening PR:** [#1343](https://github.com/lidge-jun/opencodex/pull/1343), based exactly on merge commit `025c37916225dd685d9217e5b40190600f06d278`.
137-
- The follow-up preserves frozen CL-00 semantics and does not add CL-03 work.
138-
- Current CI/review reconciliation for #1343 must complete before the hardening
139-
follow-up is considered closed.
140-
- **CL-03:** not started.
136+
- **Post-merge hardening PR:** [#1343](https://github.com/lidge-jun/opencodex/pull/1343), based exactly on #1333 merge commit `025c37916225dd685d9217e5b40190600f06d278`.
137+
- **Final #1343 source head:** `953e75f498056edabb9c4f2b33945f6a3d081780`.
138+
- **#1343 merged to `dev`:** `eee2dab4d1bbacefce56057adad51d734f346702` on 2026-08-09.
139+
- #1343 preserved frozen CL-00 semantics and did not add CL-03 work.
140+
- React Doctor for final #1343 head passed. Cross-platform CI run `31305383591`
141+
remained in progress when the closure follow-up was opened; its completed jobs
142+
included green gates/typecheck/privacy and green test shards 1/4, 2/4, and 4/4.
143+
- One final CodeRabbit test-quality finding remained on the merged PR: the
144+
targetless purge validation regression asserted only `LabValidationError`
145+
rather than the exact `empty_purge_targets` code.
146+
- **Closure branch:** `fix/cl-02-closure-final`, based on then-current `dev`
147+
`f197529c7d8c6adbaf3f859547414698d349340d`, which contains #1343.
148+
- **Closure PR:** [#1348](https://github.com/lidge-jun/opencodex/pull/1348).
149+
- #1348 strengthens the purge regression to assert the exact error code and
150+
records the closure gate in `053_cl02_closure_gate.md`.
151+
- **CL-03:** not started. Authorization requires #1348 green CI, zero unresolved
152+
valid CodeRabbit findings, and merge to `dev`.
141153

142154
## Authorization
143155

144156
- CL-00: **ACCEPTED** (merged #1286).
145157
- CL-01: **MERGED** via #1320 at `4bb249b756abd468c675d2d92fffe4da95ad3e2a`.
146-
- CL-02: **MERGED** via #1333 at `025c37916225dd685d9217e5b40190600f06d278`; post-merge hardening is tracked in #1343.
147-
- CL-03: **NOT STARTED** pending completion/reconciliation of the CL-02 post-merge hardening follow-up.
158+
- CL-02: **MERGED** via #1333 at `025c37916225dd685d9217e5b40190600f06d278`; post-merge hardening #1343 is also **MERGED** at `eee2dab4d1bbacefce56057adad51d734f346702`; final closure is tracked in #1348.
159+
- CL-03: **NOT STARTED**. Authorization is activated by merge of #1348 after green required CI and zero unresolved valid CodeRabbit findings.
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# CL-02 closure gate
2+
3+
Date: 2026-08-09
4+
5+
This follow-up exists only to close the remaining CL-02 post-merge acceptance bookkeeping after #1343 merged. It does not begin CL-03 and does not modify frozen CL-00 compatibility semantics.
6+
7+
## Scope
8+
9+
- strengthen the final purge validation regression to assert the exact `empty_purge_targets` error code;
10+
- record #1343 as merged at `eee2dab4d1bbacefce56057adad51d734f346702`;
11+
- reconcile final CI and CodeRabbit state before authorizing CL-03.
12+
13+
## Acceptance gate
14+
15+
CL-03 remains blocked until this closure follow-up has green required CI and no unresolved valid CodeRabbit findings. Once those conditions are satisfied and this follow-up is merged to `dev`, CL-02 post-merge hardening is closed and CL-03 may start from the then-current `dev` head.

‎tests/lab-post-merge-hardening.test.ts‎

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -288,15 +288,21 @@ test("default sensitive purge removes export evidence", () => {
288288
});
289289

290290
test("purge tombstone without targets still requires a directory-scoped action", () => {
291-
expect(() => validateLabEvent(assignEventId({
292-
schemaVersion: LAB_EVENT_SCHEMA_VERSION,
293-
eventKind: "purge_tombstone",
294-
recordedAt: 1_700_000_000_500,
295-
producer: LAB_PRODUCER,
296-
producerVersion: "test",
297-
targetEventIds: [],
298-
targetArtifactDigests: [],
299-
reason: "sensitive_evidence",
300-
purgeActions: ["artifact", "ledger", "sqlite"],
301-
}))).toThrow(LabValidationError);
291+
try {
292+
validateLabEvent(assignEventId({
293+
schemaVersion: LAB_EVENT_SCHEMA_VERSION,
294+
eventKind: "purge_tombstone",
295+
recordedAt: 1_700_000_000_500,
296+
producer: LAB_PRODUCER,
297+
producerVersion: "test",
298+
targetEventIds: [],
299+
targetArtifactDigests: [],
300+
reason: "sensitive_evidence",
301+
purgeActions: ["artifact", "ledger", "sqlite"],
302+
}));
303+
throw new Error("expected empty_purge_targets validation failure");
304+
} catch (err) {
305+
expect(err).toBeInstanceOf(LabValidationError);
306+
expect((err as LabValidationError).code).toBe("empty_purge_targets");
307+
}
302308
});

0 commit comments

Comments
 (0)