Skip to content

Commit 45aff92

Browse files
committed
docs(devlog): record the triage unit's post-delivery state
Names the two items still waiting on people: #4555 green and pending the security review MAINTAINERS.md requires for a credential-destination change, and #4528 whose only CI failure is a stale-base release version line rather than anything in its diff. Records that the thread heartbeat was repointed to watch exactly those two and made read-only by construction, after an audit caught an earlier draft instructing it to close #4519 automatically on merge, which is not the verified-code-evidence standard every other close in this unit met.
1 parent 0e13d6b commit 45aff92

1 file changed

Lines changed: 30 additions & 0 deletions

File tree

‎devlog/_fin/260914_triage_round_lanes/040_outcome.md‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,3 +80,33 @@ obligation the plan assigned it. The round-2 audit found a diff sketch that
8080
referenced variables not in scope and would have cost a CI round trip. The security
8181
review found the silent regression. None of these were style notes.
8282

83+
84+
## Post-delivery state
85+
86+
Written after the rounds closed, so the next reader knows what is still moving.
87+
88+
Two items are waiting on people rather than on work. #4555 is green at
89+
`e8b36b0e202025780e84759542a78cb1488b2333` and needs the explicit security review
90+
MAINTAINERS.md requires for a credential-destination change; the `dev`
91+
self-integration exception covers a missing second approval and not that review.
92+
#4528 had never run CI until tonight's approval, and its one failure is
93+
`release version line > the in-tree version is never behind a released one` — a
94+
stale-base failure caused by the release train opening `dev` at 2.55.0, not by
95+
anything in the diff. The author was told that a rebase should clear it.
96+
97+
The thread heartbeat was repointed from the four finished lanes to exactly those
98+
two pull requests. It is read-only by construction: an absolute no-write rule, and
99+
an explicit instruction that a merge of #4555 notifies with the merge SHA and
100+
leaves #4519 open for a human to close after checking the landed code. That rule
101+
exists because an earlier draft of the same automation told it to close the issue
102+
automatically, and an audit caught that `state == MERGED` is not the
103+
verified-code-evidence standard this unit used for every other close.
104+
105+
Two details in that automation are worth keeping if it is ever rewritten. It must
106+
not use `reviewDecision` to detect the reviewer: that field never says who reviewed,
107+
and a COMMENTED security review leaves it at `REVIEW_REQUIRED`, which is the likely
108+
shape of the review being waited on. And it keys the CI verdict off
109+
`gh run list --workflow ci.yml --commit <full sha>` rather than the check-run array,
110+
because the array mixes a cancelled entry with later successful copies of the same
111+
name and cannot answer "is the current head green".
112+

0 commit comments

Comments
 (0)