Skip to content

Commit 3a643aa

Browse files
committed
fix(actions): harden issue-triage review findings
Validate model-returned issue IDs against existing.json, sanitize/caps duplicate reasons before commenting, and use a random multiline delimiter for translated_body job outputs.
1 parent 6002e09 commit 3a643aa

1 file changed

Lines changed: 29 additions & 6 deletions

File tree

‎.github/workflows/issue-triage.yml‎

Lines changed: 29 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,8 @@ jobs:
6060
fs.appendFileSync(process.env.GITHUB_OUTPUT, 'requires_translation=true\n');
6161
fs.appendFileSync(process.env.GITHUB_OUTPUT, 'detected_language=' + (parsed.detected_language || 'non-English') + '\n');
6262
fs.appendFileSync(process.env.GITHUB_OUTPUT, 'translated_title=' + (parsed.translated_title || '').slice(0, 256) + '\n');
63-
fs.appendFileSync(process.env.GITHUB_OUTPUT, 'translated_body<<BODY_EOF\n' + (parsed.translated_body || '') + '\nBODY_EOF\n');
63+
const bodyDelim = 'BODY_' + require('crypto').randomBytes(16).toString('hex');
64+
fs.appendFileSync(process.env.GITHUB_OUTPUT, 'translated_body<<' + bodyDelim + '\n' + (parsed.translated_body || '') + '\n' + bodyDelim + '\n');
6465
"
6566
6667
apply-translation:
@@ -175,13 +176,28 @@ jobs:
175176
let parsed;
176177
try { parsed = JSON.parse(raw.trim()); }
177178
catch { try { parsed = JSON.parse(raw.replace(/^\`\`\`(?:json)?\s*/,'').replace(/\s*\`\`\`\s*$/,'').trim()); } catch { process.exit(0); } }
179+
const fs = require('fs');
178180
const cur = String(process.env.ISSUE_NUMBER);
179-
const normalize = (value) => [...new Set((Array.isArray(value) ? value : []).map(String).filter(n => n && n !== cur))];
181+
const known = new Set(
182+
JSON.parse(fs.readFileSync('existing.json', 'utf8'))
183+
.map(({ number }) => String(number))
184+
);
185+
const normalize = (value) => [...new Set(
186+
(Array.isArray(value) ? value : [])
187+
.map((entry) => String(entry).trim())
188+
.filter((number) => number !== cur && known.has(number))
189+
)];
190+
const sanitizeReason = (raw) => String(raw || '')
191+
.replace(/[\u0000-\u001f\u007f]/g, ' ')
192+
.replace(/@/g, '(at)')
193+
.replace(/[\x60*_~<>\[\]()#|]/g, '')
194+
.replace(/\s+/g, ' ')
195+
.trim()
196+
.slice(0, 240);
180197
const duplicates = normalize(parsed?.duplicates ?? parsed?.issues).slice(0, 5);
181198
const related = normalize(parsed?.related).filter(n => !duplicates.includes(n)).slice(0, 5);
182-
const reason = String(parsed?.reason || '').trim() || 'No clear duplicates or related issues found.';
199+
const reason = sanitizeReason(parsed?.reason) || 'No clear duplicates or related issues found.';
183200
if (!duplicates.length && !related.length) process.exit(0);
184-
const fs = require('fs');
185201
fs.appendFileSync(process.env.GITHUB_OUTPUT, 'matches=' + JSON.stringify({ duplicates, related, reason }) + '\n');
186202
"
187203
@@ -209,9 +225,16 @@ jobs:
209225
const related = Array.isArray(payload)
210226
? []
211227
: (Array.isArray(payload.related) ? payload.related : []);
228+
const sanitizeReason = (raw) => String(raw || '')
229+
.replace(/[\u0000-\u001f\u007f]/g, ' ')
230+
.replace(/@/g, '(at)')
231+
.replace(/[\x60*_~<>\[\]()#|]/g, '')
232+
.replace(/\s+/g, ' ')
233+
.trim()
234+
.slice(0, 240);
212235
const reason = Array.isArray(payload)
213236
? ''
214-
: String(payload.reason || '').trim();
237+
: sanitizeReason(payload.reason);
215238
if (!duplicates.length && !related.length) return;
216239
217240
const sections = [MARKER];
@@ -222,7 +245,7 @@ jobs:
222245
sections.push('Possibly related issues:', '', related.map(n => `- #${n}`).join('\n'), '');
223246
}
224247
if (reason) {
225-
sections.push(`Reason: ${reason}`, '');
248+
sections.push('Reason: ' + reason, '');
226249
}
227250
sections.push('_Detected automatically via GitHub Models._');
228251
const body = sections.join('\n');

0 commit comments

Comments
 (0)