Repository navigation
Commit 3569242
committed
fix(ci): repair the three failures the Windows panic was hiding
With the Bun worker panic gone, `bun test` reached the end of the suite on
windows-latest for the first time and reported 10 real failures. None are new;
the crash simply killed the run at 38s, before any of them could execute.
1. `scripts/release.ts` — `Bun.spawn(["npm", ...])` cannot resolve a Windows
`.cmd` shim. `Bun.$` can, which is why only the three `runQuiet` callers
broke. Those run in the release preflight, the very first step, so the
script aborted before invoking a single shim: the tests saw exit 1 and an
empty call log. Resolve through `Bun.which` with PATHEXT candidates.
2. `tests/test-home-guard.test.ts` — `URL.pathname` is not a filesystem path on
Windows (`/D:/a/...`). The leading slash made `cwd` invalid, and
`Bun.spawnSync` blamed the executable instead: `ENOENT ... bun.exe`, for a
Bun that was exactly where setup-bun left it. Use `fileURLToPath` for `cwd`
and keep the `file://` href for specifiers interpolated into probe source,
so Windows backslashes cannot be eaten as string escapes.
3. `gui/tests/client-resource-poll.test.tsx` — a 1s `waitFor` ceiling. The
visibility test waits on a real 20ms interval plus a React commit, which a
loaded macOS runner missed mid-suite while the same file passed alone. The
assertion is whether the fetch happens, never how fast, so 5s costs a
healthy run nothing. Its failure also cascaded into the next file's
`window.event` teardown error.
Evidence: 6190 pass / 0 fail across 445 files, 427 GUI tests pass, typecheck
clean.1 parent c300c6f commit 3569242
3 files changed
Lines changed: 59 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
30 | 38 | | |
31 | 39 | | |
32 | 40 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
42 | 64 | | |
43 | | - | |
| 65 | + | |
44 | 66 | | |
45 | 67 | | |
46 | 68 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
19 | | - | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
20 | 38 | | |
21 | 39 | | |
22 | 40 | | |
| |||
50 | 68 | | |
51 | 69 | | |
52 | 70 | | |
53 | | - | |
54 | | - | |
55 | | - | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
56 | 74 | | |
57 | 75 | | |
58 | 76 | | |
| |||
79 | 97 | | |
80 | 98 | | |
81 | 99 | | |
82 | | - | |
| 100 | + | |
83 | 101 | | |
84 | 102 | | |
85 | 103 | | |
| |||
91 | 109 | | |
92 | 110 | | |
93 | 111 | | |
94 | | - | |
| 112 | + | |
95 | 113 | | |
96 | 114 | | |
97 | 115 | | |
| |||
105 | 123 | | |
106 | 124 | | |
107 | 125 | | |
108 | | - | |
| 126 | + | |
109 | 127 | | |
110 | 128 | | |
111 | 129 | | |
| |||
119 | 137 | | |
120 | 138 | | |
121 | 139 | | |
122 | | - | |
| 140 | + | |
123 | 141 | | |
124 | 142 | | |
125 | 143 | | |
| |||
133 | 151 | | |
134 | 152 | | |
135 | 153 | | |
136 | | - | |
| 154 | + | |
137 | 155 | | |
138 | 156 | | |
139 | 157 | | |
| |||
0 commit comments