Repository navigation
Commit 3468cea
committed
fix(google-antigravity): keep the sentinel out of the real-signature path
Exact-head CI failed three shards that the focused suite did not show — this
round's own gate 4 firing on me, since I chose the targets. Five tests in four
other suites assert thoughtSignature === undefined and the sentinel filled it.
Investigating those five surfaced two REAL defects, not just assertion drift:
1. observeAntigravityReplay cached the sentinel as if it were a genuine
signature, so a fabricated token round-tripped into the replay cache and was
replayed later as evidence a turn was signed. extractSignature now refuses
it on both the direct and nested paths; observing it leaves the cache empty
(0 sessions) instead of storing it.
2. isLikelyRealThoughtSignature accepted it — the sentinel is alphanumeric with
underscores, so it passed every filter that rejects fc_/ctc_/tsc_ synthetic
ids. It is now rejected by name, which is what the issue #174 tests were
protecting: a fabricated id must never be treated as real.
With both closed, the five assertions are genuinely proxies. They read
'undefined' to mean 'nothing was borrowed from another call, thread, or
namespace', and a constant carries no other call's identity. Verified directly:
thread-a records a real signature, thread-b replays the same call in a different
session, and thread-b receives the sentinel — never thread-a's value. Each
assertion now expects the sentinel and states why the property still holds.
The PR body for #2693 confirms the sentinel belongs on replayed history too:
upstream rejects any multi-turn functionCall lacking a signature, not just the
current turn. So narrowing it to fresh turns would reintroduce the 400.
159 pass / 0 fail across all four affected suites; tsc exit 0.1 parent d829215 commit 3468cea
5 files changed
Lines changed: 21 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
512 | 512 | | |
513 | 513 | | |
514 | 514 | | |
515 | | - | |
| 515 | + | |
516 | 516 | | |
517 | 517 | | |
518 | | - | |
| 518 | + | |
519 | 519 | | |
520 | 520 | | |
521 | 521 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
32 | 37 | | |
33 | 38 | | |
34 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
777 | 777 | | |
778 | 778 | | |
779 | 779 | | |
780 | | - | |
| 780 | + | |
| 781 | + | |
| 782 | + | |
| 783 | + | |
781 | 784 | | |
782 | 785 | | |
783 | 786 | | |
| |||
797 | 800 | | |
798 | 801 | | |
799 | 802 | | |
800 | | - | |
| 803 | + | |
| 804 | + | |
801 | 805 | | |
802 | 806 | | |
803 | 807 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
311 | 311 | | |
312 | 312 | | |
313 | 313 | | |
314 | | - | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
315 | 317 | | |
316 | 318 | | |
317 | 319 | | |
| |||
430 | 432 | | |
431 | 433 | | |
432 | 434 | | |
433 | | - | |
| 435 | + | |
| 436 | + | |
434 | 437 | | |
435 | 438 | | |
436 | 439 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
126 | 126 | | |
127 | 127 | | |
128 | 128 | | |
129 | | - | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
130 | 132 | | |
131 | 133 | | |
132 | 134 | | |
| |||
0 commit comments