Repository navigation
Commit 3307261
committed
fix(log-guard): key the inspection cache on file identity, not size+mtime
Re-review showed size:mtimeMs is not an identity: an atomic replace (write a
new file, rename over the old) can preserve both, and the cache then served the
previous schema/capability verdict indefinitely. That trades a repeated-scan
cost for a persistent wrong answer, which is the worse failure.
The key now includes dev+ino (a replaced file is a different inode) and
nanosecond mtime/ctime (an in-place rewrite inside one millisecond still
invalidates), via statSync(path, { bigint: true }).
Regression drives the exact case: replace the database with a same-size
non-database file, restore the original mtime, and assert the next inspection
is neither the cached object nor still 'compatible'.1 parent bd73793 commit 3307261
2 files changed
Lines changed: 41 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
181 | 181 | | |
182 | 182 | | |
183 | 183 | | |
184 | | - | |
185 | | - | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
186 | 199 | | |
187 | 200 | | |
188 | 201 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
| 10 | + | |
9 | 11 | | |
10 | 12 | | |
11 | 13 | | |
| |||
445 | 447 | | |
446 | 448 | | |
447 | 449 | | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
448 | 474 | | |
0 commit comments