Skip to content

Commit 32ebcc0

Browse files
authored
Merge pull request #1969 from lidge-jun/codex/wave5-final-record
docs(devlog): publish the remaining Wave 5 record corrections
2 parents d23b7e8 + c9ea659 commit 32ebcc0

1 file changed

Lines changed: 35 additions & 6 deletions

File tree

‎devlog/_plan/260817_wave5_execution/090_wave6_closeout.md‎

Lines changed: 35 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ misleading in this checkout.
1717
and still not the required gate.
1818
- **#1795** does not close without a live SenseNova/Kimi canary showing zero
1919
undeclared tool calls.
20-
- **#1843** is closable now: fixed by #1860, released in v2.24.2.
20+
- **#1843** is closable now: fixed by #1860, released in **v2.24.0** (`git tag --contains ac8c0d2df`
21+
names v2.24.0 as the earliest containing tag; an earlier draft of this line said v2.24.2).
2122
- State is judged by merge commit and branch ancestry first, GitHub API second,
2223
cached HTML badges last. #1881 showed an Open badge while merged.
2324

@@ -234,11 +235,20 @@ false, and it is the worst error in this campaign's record: an approver reading
234235
promoted past a high-severity finding that this campaign created, on my assurance that it had
235236
not. Corrected in both PR bodies, reported on #1897, and recorded here.
236237

237-
**Why my verification missed it.** Before merging #1897 I ran the focused suites and `tsc`
238-
locally, because no CI run existed at its head. Neither runs CodeQL. The alert surfaced on the
239-
promotion PRs, where CodeQL diffs the whole branch rather than a feature slice — so the
240-
substitution I made for missing CI covered the tests and silently did not cover static analysis.
241-
That is a real gap in the local-verification substitute, not a one-off.
238+
**Why my verification missed it — and my first explanation was wrong too.** I wrote that the
239+
cause was substituting local tests for missing CI, since neither runs CodeQL. That is true and
240+
irrelevant: **CodeQL would not have run on #1897 even with full CI at its head.** The analysis
241+
history contains `refs/heads/main`, `refs/heads/dev`, and `refs/pull/*/head` only for PRs
242+
targeting the default branch. Every campaign PR targets `dev`, so none of them could receive
243+
CodeQL feedback at all — verified: `refs/pull/1959/head` and `refs/pull/1963/head` have analyses
244+
because they target `main`, while the `preview`-targeting pair have zero.
245+
246+
The actual root cause is duller and more useful: **`dev` is scanned on push, and nobody read
247+
the result.** It carries 84 open alerts against `main`'s 71. The finding was observable on the
248+
integration branch from the moment #1897 merged until promotion, and no step in this campaign
249+
ever looked. CodeQL is structurally absent from the `dev` PR flow *and* the post-merge alert
250+
list is not part of anyone's gate — those are two different holes, and I named neither the
251+
first time.
242252

243253
Severity in context: the input is a configured `baseUrl`, so exploitation needs a hostile or
244254
careless config rather than attacker-controlled traffic. Worth fixing, not urgent. Separately,
@@ -266,3 +276,22 @@ does not include CodeQL.
266276
For context rather than excuse: the repository carries 71 open alerts, 65 of them high or
267277
critical. This is one of many — but it is one this campaign put there, so it gets fixed here
268278
rather than added to the pile.
279+
## Promotion: completed, and not by the PRs I opened
280+
281+
`dev` reached `preview` and `main`. Not through #1958/#1959, which I opened and deliberately
282+
left for a maintainer — those flipped to merged seconds *after* **#1962** and **#1963** did the
283+
actual promotion at 02:55:01 and 02:55:04, because their heads became reachable once the real
284+
promotion landed.
285+
286+
Which means the disclosure I spent three rounds getting right went onto the two PRs that did not
287+
move any code, and the two that did carried none of it. Corrected by commenting the full
288+
disclosure onto #1962 and #1963 after the fact — later than it should have been, and worth
289+
recording as the failure mode it is: **I attached a warning to the artifact I controlled rather
290+
than to the artifact that would carry the change.**
291+
292+
`js/polynomial-redos` is now on `main` — `git merge-base --is-ancestor 0be660a2e origin/main`
293+
returns true. The alert is disclosed on #1897, on both promotion PR pairs, and here.
294+
295+
What I did not do, and stand by: I never approved a promotion PR. `MAINTAINERS.md` forbids
296+
authors approving their own, and the rulesets require a code-owner review. That the promotion
297+
happened by another route is the maintainer's call to make, not mine to route around.

0 commit comments

Comments
 (0)