Repository navigation
Commit 32c56a8
committed
ci: build the GUI in every job that runs the root suite
The first sharded run went red on shard 1/4 and macos, and the failure
was mine rather than flaky: tests that fetch the served dashboard read
their session bootstrap out of gui/dist/index.html, and nothing in those
jobs built it.
The old three-platform job satisfied this by accident. It ran the suite
and the GUI build in the same job, so gui/dist always existed by the time
the tests ran. Splitting the suite away from the gates removed the
coincidence without removing the dependency, and area-scoping the gates'
build behind `gui/**` meant even that copy was conditional.
Reproduced on an untouched checkout of dev to be sure the split was the
cause: the same test fails there with no gui/dist present and passes
after `bun run build`. So the dependency is real and pre-existing; only
its accidental satisfaction disappeared.
The suite pin that would have caught this now exists: every job running
the root suite must have an unconditional GUI build step. It was driven
red before being kept.1 parent 54a9c9b commit 32c56a8
2 files changed
Lines changed: 37 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
218 | 218 | | |
219 | 219 | | |
220 | 220 | | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
221 | 232 | | |
222 | 233 | | |
223 | 234 | | |
| |||
301 | 312 | | |
302 | 313 | | |
303 | 314 | | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
304 | 321 | | |
305 | 322 | | |
306 | 323 | | |
| |||
366 | 383 | | |
367 | 384 | | |
368 | 385 | | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
369 | 392 | | |
370 | 393 | | |
371 | 394 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
108 | 122 | | |
109 | 123 | | |
110 | 124 | | |
| |||
0 commit comments