Repository navigation
Commit 2ffb701
committed
fix(devin-cli): make the provider configurable, reap the tree, keep the turn alive
Four findings from the PR review, all real.
The registry destination devin://acp/stdio could never be configured:
providerBaseUrlConfigError accepts only http(s), so selecting the preset -
including through ocx init - produced a config the loader rejects before routing
could reach runTurn. It is now https://cli.devin.ai, a canonical identity URL
rather than a transport, which is the shape the other CLI-backed providers
already use.
Signalling the direct pid left Devin's own subprocesses running. Once
OPENCODEX_DEVIN_CLI_ALLOW_TOOLS lets it launch a shell, neither SIGTERM nor the
later SIGKILL reached the descendants, so an abort could return while a tool
kept writing in the operator's tree. The child now gets its own process group on
POSIX and the reap signals the group, falling back to the single process.
Internal ACP tool notifications became heartbeats instead of nothing. Dropping
them entirely meant a Devin tool operation longer than the bridge's stall
timeout looked like upstream silence, and the still-working turn was aborted.
They are still not client tools.
A malformed frame after the protocol starts now fails the turn. Treating every
parse failure as banner noise silently lost a session/update, or waited out the
ten-minute timeout for a reply that had already arrived damaged. Plain text is
still accepted before the first valid frame.
structure/adapters/registry.md records why devin-cli is a direct registry entry
and why its baseUrl is an identity rather than a destination.1 parent dd889ea commit 2ffb701
13 files changed
Lines changed: 106 additions & 22 deletions
File tree
- docs-site/src/content/docs
- fr/guides
- guides
- ja/guides
- ko/guides
- ru/guides
- tr/guides
- zh-cn/guides
- zh-tw/guides
- src
- adapters/devin-cli
- providers
- structure/adapters
- tests/providers
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
128 | | - | |
| 128 | + | |
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
191 | 191 | | |
192 | 192 | | |
193 | 193 | | |
194 | | - | |
| 194 | + | |
195 | 195 | | |
196 | 196 | | |
197 | 197 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
117 | | - | |
| 117 | + | |
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
115 | | - | |
| 115 | + | |
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
126 | | - | |
| 126 | + | |
127 | 127 | | |
128 | 128 | | |
129 | 129 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
141 | | - | |
| 141 | + | |
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
109 | | - | |
| 109 | + | |
110 | 110 | | |
111 | 111 | | |
112 | 112 | | |
| |||
0 commit comments