You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 2e1c211
Browse filesBrowse the repository at this point in the historyBrowse files
fix(ci): give the Windows leg the budgets and the crash retry it never had
Six shard failures in three groups (#2152). None came from main..dev;
all three needed a different answer, and none of them was skipping a
test that can actually run.
Group 1, budgets. watchdogMs is a FLOOR, not a multiplier, so a case
calling watchdogMs(30_000) still got exactly 30s -- 'Restore truth'
failed at 30,147ms. Windows CI now floors at 45s, under the lane's own
60s per-test timeout so a hung test stays bounded.
'A-reduced' was misread in the issue: its 79,978ms was elapsed time
against a 150s ceiling, so the outer budget was never the constraint.
The real failure was Fixture.request's unscaled 10s AbortSignal, which
aborted the case from inside. It is scaled now like every neighbouring
budget.
'E' does not start ocx at all. Its lock holder released after a fixed
3s busy wait, and on a Windows shard the contender's process spawn can
outlast that -- the parent then sees 'acquired' where it demands 'busy',
which reads as a broken exclusion invariant rather than a hold that
expired early. The release-marker handshake still ends the hold early
everywhere else; only the ceiling moved.
Group 2, skip guard. The issue says an unprivileged Windows user cannot
create symlinks, but the GitHub runner can -- so canSymlink was true,
the cases ran, and they failed on how the preflight reads mode and
access through a Windows symlink. Two neighbouring cases in the same
file already skip on process.platform === "win32"; these three now use
that same guard, and keep the capability check for unprivileged POSIX.
Group 3, crash retry. A Bun panic is a crash in the interpreter, not a
test result. The macOS leg has carried a crash-signature retry for this;
the Windows shards, a separate matrix job with their own one-shot
command, had none. They now use the same wrapper, extended with
panic(thread since that is the signature this leg actually printed.
An assertion failure returns its status immediately and is never
retried.
What this cannot prove locally: whether 45s is sufficient under real
Windows shard contention, the actual skip result on the runner, and
PIPESTATUS behavior in Git Bash. Those need a Windows CI dispatch, which
is the evidence to look for on this PR.
0 commit comments