Repository navigation
Commit 2d3c05f
authored
fix(codex): refresh the catalog when paginated history refuses injection (#4411)
* fix(codex): refresh the catalog when paginated history refuses injection
An explicit `ocx sync` is also the refresh path for side profiles that consume
the OpenCodex catalog without injection. Since paginated Codex rollouts began
refusing external writes, that refusal was reaching `syncModelsToCodex` through
the validate-only preflight and failing the whole sync, so the model catalog
went stale on a home whose history simply requires its native writer.
The preflight refusal now carries a structured
`historyPreflightFailureReason` instead of only display text. When an explicit
sync sees `history_paginated_requires_native_writer`, it keeps the injector's
refusal intact, publishes through the existing catalog owner, and returns
`catalog-only` with config and conversation files untouched. Unattended sync
and every other config or integrity refusal keep their hard failure.
`refreshOutcome` distinguishes a validated catalog commit from a refused
refresh, so `refreshCodexModelCatalog` no longer rewrites the models cache
after a refusal and `ocx sync` exits non-zero when a catalog-only refresh did
not complete.
* docs(devlog): record the 2.43/2.46 releases and the open closeout units
Carries the planning and delivery records that were still sitting untracked in
the working tree: the 2.43 and 2.46 release units, the per-work-phase execution
and delivery records for the 260905 open-work closeout, the provider runtime
stack unit, the 249 bulk closeout, and the beginner PDF plan.
The 006 dispositions and 060 ledger updates record two maintainer decisions
made during that campaign: `bun run test:changed` was removed from the local
verifier set because its import-graph selection reaches most of the suite on
the touched layers, and from wp4 onward the campaign accepted the final `dev`
tip CI run as batch evidence instead of per-PR exact-head runs.
* test(codex): cover the catalog-only path for a paginated-history refusal
Three cases the change has to keep apart: an explicit sync refreshes the
catalog and reports `catalog-only` when the injector refuses on
`history_paginated_requires_native_writer`; a refused refresh under the same
condition stays unsuccessful and writes no cache; and an unattended sync keeps
the hard failure it always had.
* fix(devlog): drop a maintainer email address from the wp4 reverify record
`privacy:scan` flags any address outside its allowlist, and the carried
closeout record quoted the `-c user.email` value used to re-author two layers.
The address was never the point of the note, so it is replaced with a
description of the flag pair. This is what failed `test 3/4`, `gates`, and
`macos 2/2` on the previous head.
* docs(structure): record the catalog-only exception and declare refreshOutcome
Two residuals a delegated review found on this PR. `structure/config.md` owns
the sync preflight contract and still said every deterministic refusal leaves
the catalog and cache untouched, which this change makes untrue for one reason
code. And `refreshOutcome` reached callers through a spread without ever being
declared on `CodexSyncResult`.1 parent 213065e commit 2d3c05f
64 files changed
Lines changed: 10091 additions & 6 deletions
File tree
- devlog
- _fin
- 260906_release_243
- 260907_release_246
- _plan
- 260905_open_work_closeout
- 260908_provider_runtime_stack
- 260909_bulk_closeout_249
- 260912_beginner_pdf
- src
- cli
- codex
- catalog
- structure
- tests/codex-integration
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
0 commit comments