Skip to content

Commit 2c18223

Browse files
committed
test(streaming): harden relay regression coverage
1 parent e247a0d commit 2c18223

2 files changed

Lines changed: 37 additions & 19 deletions

File tree

‎tests/relay-eager.test.ts‎

Lines changed: 36 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -260,24 +260,42 @@ describe("relaySseEagerBounded — inline payload rewrite (#864)", () => {
260260
const upstream = new AbortController();
261261
const { hooks, rec } = makeHooks();
262262
hooks.rewritePayload = (payload: string) => payload;
263-
const relayed = relaySseEagerBounded(up.stream, upstream, hooks, {
264-
rewriteBudget: budget,
265-
postCancelDrainMs: 20,
266-
});
267-
const reader = relayed.getReader();
268-
269-
up.push(enc.encode(`data: {"type":"response.created","padding":"${"x".repeat(256 * 1024)}`));
270-
await settle();
271-
expect(budget.snapshot().currentBytes).toBeGreaterThan(0);
272-
273-
await reader.cancel();
274-
await settle(60);
275-
276-
expect(upstream.signal.aborted).toBe(true);
277-
expect(budget.snapshot().currentBytes).toBe(0);
278-
expect(rec.cancels).toBe(1);
279-
expect(rec.dones).toBe(1);
280-
expect(rec.synthetics).toEqual([]);
263+
let resolveDone!: () => void;
264+
const done = new Promise<void>(resolve => { resolveDone = resolve; });
265+
const previousOnDone = hooks.onDone;
266+
hooks.onDone = () => {
267+
try { previousOnDone(); } finally { resolveDone(); }
268+
};
269+
let timeout: ReturnType<typeof setTimeout> | undefined;
270+
271+
try {
272+
const relayed = relaySseEagerBounded(up.stream, upstream, hooks, {
273+
rewriteBudget: budget,
274+
postCancelDrainMs: 20,
275+
});
276+
const reader = relayed.getReader();
277+
278+
up.push(enc.encode(`data: {"type":"response.created","padding":"${"x".repeat(256 * 1024)}`));
279+
await settle();
280+
expect(budget.snapshot().currentBytes).toBeGreaterThan(0);
281+
282+
await reader.cancel();
283+
await Promise.race([
284+
done,
285+
new Promise<never>((_, reject) => {
286+
timeout = setTimeout(() => reject(new Error("relay cleanup timed out")), 2_000);
287+
}),
288+
]);
289+
290+
expect(upstream.signal.aborted).toBe(true);
291+
expect(budget.snapshot().currentBytes).toBe(0);
292+
expect(rec.cancels).toBe(1);
293+
expect(rec.dones).toBe(1);
294+
expect(rec.synthetics).toEqual([]);
295+
} finally {
296+
if (timeout) clearTimeout(timeout);
297+
budget.dispose();
298+
}
281299
});
282300

283301
test("blocks without a data field pass through untouched", async () => {

‎tests/responses-image-gen-repair.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ describe("Responses image-gen call restoration", () => {
347347
expect(isEagerRelaySseResponse(response)).toBe(
348348
process.platform === "win32" || process.platform === "darwin",
349349
);
350-
expect(clientBody.length).toBeGreaterThan(largeEcho.length);
350+
expect(clientBody).toContain(largeEcho);
351351
expect(clientBody).not.toContain("image_gen__imagegen");
352352
expect(clientBody.match(/\"namespace\":\"image_gen\"/g)).toHaveLength(3);
353353
expect(clientBody.match(/event: response\.completed/g)).toHaveLength(1);

0 commit comments

Comments
 (0)