Repository navigation
Commit 2483f40
committed
fix(errors): narrow the server-class override to the 400 verdict only
Exact-head CI caught what my focused suites missed: the first version of this
fix returned a blanket 502 for any structured server class, which flattened
genuine 504 and 503 verdicts and broke tests/web-search-timeout-contract.ts
(a routed-body stall is really a gateway timeout, and the log surface asserts
504). Reproduced locally: 2 fail in that suite.
The classification is authoritative about blame, not about which server status
fits. So message inference still picks the specific status, and only the 400
verdict is overridden — the one case that both blames the caller and stops the
retry. 429, 499, 401 and 403 are left alone because each is a signal the caller
routes on, and overriding them would trade one misreport for another.
Differential probe vs origin/dev: exactly two cases change, both 400 -> 502
(upstream 5xx carrying 'malformed' or 'invalid request' text). 504, 503, 429,
499, cyber-policy 400, auth 401, permission 403, real invalid_request 400,
proxy_error 500 and the no-message 502 default are all unchanged.
210 pass / 0 fail across the nine suites that touch this function. Mutation
oracle still holds: 45/1 without the fix, 46/0 with it.1 parent 93975ab commit 2483f40
1 file changed
Lines changed: 19 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
404 | 404 | | |
405 | 405 | | |
406 | 406 | | |
407 | | - | |
408 | | - | |
409 | | - | |
410 | | - | |
411 | | - | |
412 | | - | |
413 | | - | |
414 | | - | |
415 | 407 | | |
416 | 408 | | |
417 | 409 | | |
418 | 410 | | |
419 | 411 | | |
420 | 412 | | |
421 | | - | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
422 | 432 | | |
423 | 433 | | |
0 commit comments