You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 1f4e047
Browse filesBrowse the repository at this point in the historyBrowse files
Copy file name to clipboardExpand all lines: devlog/_plan/260817_wave5_execution/090_wave6_closeout.md
+140-2Lines changed: 140 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -71,7 +71,7 @@ of them:
71
71
72
72
| PR | Held because |
73
73
|----|--------------|
74
-
|#1891|it makes `GOOGLE_ANTIGRAVITY_USER_AGENT` steerable into the `onboardUser` request body, violating this wave's accept criterion. Needs #1889 first, which is the one-line fix that makes `ide_version` a real constant. Detail in `080`.|
74
+
|#1891|**held during the campaign, then merged afterwards** as `5c66ad205` — see the correction below|
75
75
|#1889| unsponsored `src/oauth/` surface, plus still draft. The `maintainer-sponsored` label is the record that a security review happened, so an agent applying it would falsify that record. |
76
76
77
77
Neither is affected by the close-on-dev-merge decision: both are blocked *before* merge, so the
@@ -104,7 +104,7 @@ worth making about the policy change. It removed a gate that was never what held
104
104
105
105
### Promotion state
106
106
107
-
`dev` carries nine merged PRs from this campaign. `preview` and `main` are both behind it, and
107
+
`dev` carries this campaign's merges. `preview` and `main` are both behind it, and
108
108
`dev`'s own hosted CI has no completed green run on its current head — the runs at `2b12521ee`
109
109
and `aca3c0241` were both cancelled by supersession as later merges landed. The local full
110
110
suite above is the evidence that exists; a hosted run on the exact promotion head is the
@@ -128,3 +128,141 @@ all three OSes, npm-global on all three, gates, storage policy, api usage.
128
128
129
129
So the hosted evidence now exists. Promote the head CI actually evaluated; promoting a local ref
130
130
that no run has seen would re-open the exact gap this section was written about.
131
+
## Correction: #1891 merged, and the record said otherwise
132
+
133
+
I held #1891 and argued #1889 must land first, because #1889 is the one-line fix that makes
134
+
`ide_version` a real constant. **#1891 merged at 02:25:46Z as `5c66ad205` without it. #1889 is
135
+
still open and draft.**
136
+
137
+
For a while this document, and both promotion PR descriptions, described #1891 as deliberately
138
+
excluded while it was sitting on the promotion head. That is the worst kind of error in a record
139
+
meant to inform an approval: a maintainer reading it would have approved a promotion believing
140
+
it excluded a change it contained. Corrected in all three places.
141
+
142
+
The underlying concern *is* addressed on this head, by a different route than the hold pointed
143
+
at: **#1955** (merge `19464a720`, commit `e9b2a0a63`) changed `ide_version` to
144
+
`ANTIGRAVITY_IDE_VERSION`, so the body field no longer carries the User-Agent at all. The hold
145
+
was right about the defect and wrong about which PR would fix it.
146
+
147
+
*Attribution corrected: I first credited this to **#1957**, which is documentation-only — its
148
+
merge `c3bf2c295` touches two devlog files and zero code. Its title mentions the fix because it
149
+
carried the record of it, three minutes after #1955 landed the code. `git log -S 'ide_version:
150
+
ANTIGRAVITY_IDE_VERSION'` returns exactly one commit, and it is #1955's. A maintainer checking
151
+
#1957's diff to verify the claim would have found no code and had good reason to distrust the
152
+
rest of this document.*
153
+
154
+
Two smaller corrections in the same pass:
155
+
156
+
-**"every subsequent hosted run on `dev` is green"** was not backed. **Six or more** of the runs
157
+
after `9dbc5fc42` are *cancelled* by supersession, and cancelled is not green. The accurate
158
+
statement is that the completed runs after it are green, and most never completed — this
159
+
branch supersedes its own runs faster than they finish.
160
+
-**The PR count is dropped rather than corrected, and this time actually dropped.** I wrote
161
+
nine, then ten, then claimed to drop it while leaving "nine merged PRs" standing in the
162
+
Promotion state section and substituting an equally underived "seventeen" here. Three wrong
163
+
numbers and a false claim to have stopped giving numbers.
164
+
165
+
The derived figure, for anyone who wants one: **23** merge commits between `v2.24.2`
166
+
(`474584bcd`) and the promotion head touch `src/` or `tests/`, out of 32 merges total. That
167
+
range includes work outside this campaign, which is exactly why the per-PR accounting in the
168
+
wave documents is the thing to read instead of a headline count.
169
+
- The closure-rules section still says #1843 was "released in v2.24.2"; the results table saying
170
+
**v2.24.0** is the correct one, confirmed by `ac8c0d2df` being contained in that tag.
0 commit comments