Skip to content

Commit 17a6e5f

Browse files
committed
test(providers): cover capability mutation isolation and overwrite preservation
1 parent 5cd76c5 commit 17a6e5f

2 files changed

Lines changed: 50 additions & 1 deletion

File tree

‎tests/cli/cli-provider.test.ts‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -644,3 +644,16 @@ describe("ocx provider add --sync", () => {
644644
}
645645
});
646646
});
647+
648+
649+
test("provider add --force preserves all explicit model capability axes", () => {
650+
const declarations = { ModelA: { inputModalities: ["text"], contextTier: "long_context", video: { processing: "agentic" } }, modela: { inputModalities: ["text", "image"] } };
651+
const { dir } = freshConfig({ defaultProvider: "caps", providers: { caps: {
652+
adapter: "openai-chat", baseUrl: "https://example.test/v1", modelCapabilities: declarations,
653+
} } });
654+
try {
655+
const result = runCli(["provider", "add", "caps", "--adapter", "openai-chat", "--base-url", "https://example.test/v1", "--force", "--json"], { OPENCODEX_HOME: dir });
656+
expect(result.status, result.stderr).toBe(0);
657+
expect(readConfig(dir).providers.caps.modelCapabilities).toEqual(declarations);
658+
} finally { removeTreeWithRetry(dir); }
659+
});

‎tests/server/management-provider-validation.test.ts‎

Lines changed: 37 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5021,19 +5021,55 @@ test("model capability PATCH merges axes while strict replacement and DTO state
50215021
...(body === undefined ? {} : { body: JSON.stringify(body) }),
50225022
}), url, live, { createManagementConvergeCodex: catalogConvergenceFactory() }))!;
50235023
};
5024-
const before = structuredClone(live.providers.caps!.modelCapabilities);
5024+
const before = live.providers.caps!.modelCapabilities;
5025+
const originalRow = before!.ModelA!;
5026+
const originalVideo = originalRow.video;
50255027
expect((await request("PATCH", { modelCapabilities: { ModelA: { contextTier: "default", video: { processing: null } } } })).status).toBe(200);
50265028
expect(live.providers.caps!.modelCapabilities).toEqual({
50275029
ModelA: { inputModalities: ["text"], contextTier: "default" }, modela: { inputModalities: ["text", "image"] },
50285030
});
50295031
expect(before!.ModelA!.video).toEqual({ processing: "agentic" });
5032+
expect(originalRow.contextTier).toBe("long_context");
5033+
expect(originalVideo).toEqual({ processing: "agentic" });
5034+
expect(live.providers.caps!.modelCapabilities).not.toBe(before);
5035+
expect(live.providers.caps!.modelCapabilities!.ModelA).not.toBe(originalRow);
50305036
expect(loadConfig().providers.caps!.modelCapabilities).toEqual(live.providers.caps!.modelCapabilities);
50315037
const listed = await (await request("GET")).json() as Array<{ name: string; modelCapabilities?: unknown }>;
50325038
expect(listed.find(row => row.name === "caps")!.modelCapabilities).toEqual(live.providers.caps!.modelCapabilities);
50335039
expect(providerEditorConfigDTO(live).providers.caps!.modelCapabilities).toEqual(live.providers.caps!.modelCapabilities);
50345040
for (const patch of [{ " ModelA ": {} }, { ModelA: { unknown: true } }, { ModelA: { inputModalities: [] } }]) {
50355041
expect((await request("PATCH", { modelCapabilities: patch })).status).toBe(400);
50365042
}
5043+
const admitted = structuredClone(live.providers.caps!.modelCapabilities);
5044+
const diskBeforeReject = readFileSync(join(TEST_DIR, "config.json"), "utf8");
5045+
for (const patch of [JSON.parse('{"__proto__":null}'), { ModelA: { video: [] } }, { ModelA: { video: { processing: "invalid" } } }]) {
5046+
expect((await request("PATCH", { modelCapabilities: patch })).status).toBe(400);
5047+
expect(live.providers.caps!.modelCapabilities).toEqual(admitted);
5048+
expect(readFileSync(join(TEST_DIR, "config.json"), "utf8")).toBe(diskBeforeReject);
5049+
}
5050+
const resolved = spyOn(destinationPolicy, "providerDestinationResolvedError").mockResolvedValue(null);
5051+
try {
5052+
const replacement = { adapter: "openai-chat", baseUrl: "https://example.test/v1", liveModels: false, models: ["ModelA", "modela"] };
5053+
expect((await request("POST", { name: "caps", provider: replacement })).status).toBe(200);
5054+
expect(live.providers.caps!.modelCapabilities).toEqual(admitted);
5055+
expect((await request("POST", { name: "caps", provider: { ...replacement, modelCapabilities: {} } })).status).toBe(200);
5056+
expect(live.providers.caps!.modelCapabilities).toBeUndefined();
5057+
expect((await request("PATCH", { modelCapabilities: admitted })).status).toBe(200);
5058+
const stale = providerEditorConfigDTO(loadConfig());
5059+
expect((await request("PATCH", { modelCapabilities: { ModelA: { contextTier: null } } })).status).toBe(200);
5060+
expect(live.providers.caps!.modelCapabilities!.ModelA).toEqual({ inputModalities: ["text"] });
5061+
expect(live.providers.caps!.modelCapabilities!.modela).toEqual({ inputModalities: ["text", "image"] });
5062+
const staleEdit = structuredClone(stale);
5063+
staleEdit.providers.caps!.note = "stale";
5064+
expect((await request("PUT", { baseline: stale, next: staleEdit })).status).toBe(409);
5065+
expect((await request("PATCH", { modelCapabilities: { ModelA: null } })).status).toBe(200);
5066+
expect(live.providers.caps!.modelCapabilities).toEqual({ modela: { inputModalities: ["text", "image"] } });
5067+
expect((await request("PATCH", { modelCapabilities: null })).status).toBe(200);
5068+
expect(live.providers.caps!.modelCapabilities).toBeUndefined();
5069+
expect((await request("PATCH", { modelCapabilities: admitted })).status).toBe(200);
5070+
} finally {
5071+
resolved.mockRestore();
5072+
}
50375073
const baseline = providerEditorConfigDTO(loadConfig());
50385074
const invalidNext = structuredClone(baseline);
50395075
Object.assign(invalidNext.providers.caps!, { modelCapabilities: null });

0 commit comments

Comments
 (0)