Skip to content

Commit 1205947

Browse files
committed
docs(devlog): record the review round on lane I
The three findings were all the same shape -- a destination the first pass was willing to assume -- and two of them changed behaviour for model-scoped keys, so the lane note carries the reasoning rather than only the outcome.
1 parent 57562ce commit 1205947

1 file changed

Lines changed: 24 additions & 0 deletions

File tree

‎devlog/_plan/260920_meaning_preservation_batch/060_lane_i.md‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,3 +86,27 @@ files are registered in both `scripts/test-layout/layout.json` and
8686
The issue stays open for the coordinator to judge. This lane closes the four endpoints named in the
8787
#5265 adversarial review and nothing beyond them.
8888

89+
## What the first review round changed
90+
91+
Three findings on PR #5290, all of them about a destination the first pass was willing to assume.
92+
93+
The refusal marker was being used as a model id. A request that named no model was checked as the
94+
literal `(unnamed)`, which the configuration schema accepts like any other string, so an operator
95+
who copied it out of a refusal into `allowedModels` would have granted "whatever the upstream
96+
picks". The absent model is now absent: the denial helper takes an undefined model id and refuses
97+
any key carrying a model list, judging a provider-only scope on the provider alone. The marker is
98+
message vocabulary and never reaches the comparison.
99+
100+
A Realtime standalone socket was judged as the default. The external audio path read the `model=`
101+
query only for the Frameless style — the one that rewrites its own query — while a
102+
`realtime-standalone` socket forwards that parameter untouched. Both standalone styles now report
103+
the model they forward, through the helper the native path already used.
104+
105+
A join was authorized against an assumed model, and what to do about it depends on what each path
106+
can know. The external path keeps a per-key call registry, so the model a call settles on is now
107+
recorded in its `LiveCallBinding` and a rejoin is judged against it. The native compatibility path
108+
records nothing about the calls it relays and does not gain a registry here — adding call ownership
109+
to it is a different change from closing a scope hole — so a native join, and a native call-create
110+
that sends no session model, name no destination and a key carrying a model list is refused. That
111+
is a real restriction on model-scoped keys and it is written down beside the contract it
112+
constrains, in `structure/data-planes/inbound-compat.md`, rather than left to be rediscovered.

0 commit comments

Comments
 (0)