Repository navigation
Commit 10b68d2
docs(responses): stop asserting a disproven cause for the blob-preservation guard
The guard is sound, but its comments claimed it fixed Grok's `Could not decrypt
the provided encrypted_content` failure. Live bisection disproved that: Grok
emits summary-channel reasoning natively, so `reasoningItemToSummaryShape`
returns early and this rewrite never fires on that route. The real cause was
`"content": null` on the replayed reasoning item, fixed separately.
A false causal claim in a comment is worse than none — the next reader trusts it.
The rule is restated on its own terms: an item carrying opaque provider state
should not have its stored shape changed unless that backend has an explicit
replay contract, which is why DeepSeek was safe and why the Kimi/GLM/NeuralWatt
routes now on `preserveReasoningContentModels` are the ones this actually guards.
Comments and prose only; no behaviour change.
Co-Authored-By: Claude Fable 5 <[email protected]>1 parent 3d11f6f commit 10b68d2
3 files changed
Lines changed: 18 additions & 18 deletions
File tree
- src/server
- structure
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
44 | 43 | | |
45 | 44 | | |
46 | 45 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
798 | 798 | | |
799 | 799 | | |
800 | 800 | | |
801 | | - | |
802 | | - | |
803 | | - | |
804 | | - | |
805 | | - | |
806 | | - | |
807 | | - | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
808 | 809 | | |
809 | 810 | | |
810 | 811 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
210 | 210 | | |
211 | 211 | | |
212 | 212 | | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | | - | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
217 | 217 | | |
218 | 218 | | |
219 | 219 | | |
| |||
0 commit comments