You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 0776683
Browse filesBrowse the repository at this point in the historyBrowse files
fix(ci): key the Bun crash retry on the signature that is actually stable
The Windows retry added for #2152 grepped for `panic(thread`. This
repository already learned that is the wrong anchor: Bun emits BOTH
`panic(thread 2852)` and `panic(main thread)` for the same class of
failure, and devlog/_fin/260731_pr_issue_triage_round/050_windows_ci_flake_rca.md
names `Internal assertion failure` as the stable fingerprint. Verified by
literal probe -- panic(thread 3960) matched, panic(main thread) did not.
The shard would have failed on exactly the crash the retry exists for.
All three signature lists -- the macOS inline grep, the new Windows one,
and is_bun_runtime_crash in run-bun-test-batches.sh -- now carry the same
alternatives. The workflow comment already required them to stay in sync;
nothing enforced it, so three copies drifted into two shapes.
The contract test now pins the sync itself rather than the text, and pins
that no list keys on the thread-numbered form. hasShellCommandHead is
added because the existing exact-line matcher rejected the `| tee` the
retry requires, while still rejecting an echoed or commented-out copy.
Copy file name to clipboardExpand all lines: .github/workflows/ci.yml
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -516,7 +516,7 @@ jobs:
516
516
if [ "$suite_status" -eq 0 ]; then
517
517
exit 0
518
518
fi
519
-
if ! grep -Eqi 'oh no: Bun has crashed|Segmentation fault at address|Illegal instruction|Bus error|Aborted \(core dumped\)' "$suite_log"; then
519
+
if ! grep -Eqi 'oh no: Bun has crashed|Internal assertion failure|Segmentation fault at address|Illegal instruction|Bus error|Aborted \(core dumped\)' "$suite_log"; then
520
520
echo "::error::macOS suite failed on attempt ${attempt} (exit ${suite_status}); assertion failures are not retried."
521
521
exit "$suite_status"
522
522
fi
@@ -628,7 +628,7 @@ jobs:
628
628
if [ "$suite_status" -eq 0 ]; then
629
629
exit 0
630
630
fi
631
-
if ! grep -Eqi 'oh no: Bun has crashed|Segmentation fault at address|Illegal instruction|Bus error|panic\(thread' "$suite_log"; then
631
+
if ! grep -Eqi 'oh no: Bun has crashed|Internal assertion failure|Segmentation fault at address|Illegal instruction|Bus error|Aborted \(core dumped\)' "$suite_log"; then
632
632
echo "::error::Windows shard ${{ matrix.shard }}/4 failed on attempt ${attempt} (exit ${suite_status}); assertion failures are not retried."
0 commit comments