Repository navigation
Commit 045f193
committed
docs(devlog): record r7 PASS and r8 NEAR-PASS, and close the last proof gap
r7 walked the whole sequence and found nothing. Its verdict could not be recorded
because the goalplan's activeWorkPhaseId was null, and the review observer discards
any sign-off whose round targets a work-phase that is not active
(review-observer.ts:99-101). That is why r2 through r6 all had to be aborted as
inconclusive after their findings were absorbed — the findings were real, the FSM
record was not. Fixed.
r8 then re-confirmed independently and found one thing worth having: step 3 asserted
wire -> cancel -> tip but never VERIFIED_BASE -> wire, and the counts do not cover
that gap because rev-list --count A..B counts commits reachable from B and not A even
when A is not an ancestor of B. The reviewer demonstrated it against dev at
1645bb9, where --is-ancestor exits 1 while the three counts still sum. So a stack
could have passed step 3 with its bottom not on the verified base — exactly the class
of defect this plan kept failing on. The assertion is added with its reasoning inline
so nobody deletes it as redundant later.
Eight rounds, 26 findings, all absorbed. Four of them attacked the same question and
the fourth failure was the signal the question was wrong, which is recorded in 009.1 parent 86232fe commit 045f193
2 files changed
Lines changed: 82 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
| 87 | + | |
| 88 | + | |
88 | 89 | | |
| 90 | + | |
89 | 91 | | |
90 | 92 | | |
91 | 93 | | |
| |||
94 | 96 | | |
95 | 97 | | |
96 | 98 | | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
97 | 107 | | |
98 | 108 | | |
99 | 109 | | |
| |||
127 | 137 | | |
128 | 138 | | |
129 | 139 | | |
130 | | - | |
| 140 | + | |
| 141 | + | |
131 | 142 | | |
132 | 143 | | |
133 | 144 | | |
134 | 145 | | |
135 | 146 | | |
136 | 147 | | |
137 | | - | |
| |||
0 commit comments