refactor: replace connectivity Debouncer with Throttler in ConnectivityChangesNotifier#3202
Merged
veloce merged 1 commit intoMay 19, 2026
Conversation
… first-event delivery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3201
Motivation
The current implementation uses a
Debouncerwith a 5-second delay to handle rapid connectivity changes. A debouncer delays every event in a burst, including the first one. This means that when the user reconnects after a brief disconnection, the app waits a full 5 seconds before reacting and resuming socket connections or syncing correspondence moves, even when the network is already stable.Change
Replace the
Debouncerwith the existingThrottlerfromlib/src/utils/rate_limit.dart. A throttler delivers the first event in a burst immediately and suppresses subsequent events within the same time window. This preserves the protection against rapid network fluctuations while eliminating the unnecessary delay on the first reconnection event.The throttle delay is extracted into a named constant (
kConnectivityThrottleDelay) to make it configurable in tests without relying on real clock waits.Behavior difference
Testing
Existing tests pass. No new dependencies introduced.
Throttleralready exists inlib/src/utils/rate_limit.dart.