Simplify significantColors in image.dart#3165
Merged
Merged
Conversation
veloce
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old:
Map.fromiterates through every element to clone the map. ThenremoveWhereiterates through every element again.Allocates memory for a full copy of the map, including all the "trash" entries about to be deleted. This triggers the Garbage Collector more frequently.
New:
The collection
foriterates through the map exactly once, only adding what is needed.Only allocate memory for the final filtered result.
A sample test shows it produces the same result:
Starting benchmark with 50000 items...
Old Method (Map.from + removeWhere): 6199ms
New Method (Collection for): 3359ms
Efficiency Gain: 45.81%
✅ Verification Passed: Logic is identical.