feat(editor): implement separate function board clearing logic#3153
Merged
veloce merged 2 commits intoMay 12, 2026
Conversation
Collaborator
|
Thanks for your contribution! It would be great if you could add a regression test to https://github.com/lichess-org/mobile/blob/main/test/view/board_editor/board_editor_screen_test.dart (i.e. a test that would fail without your commit) |
Author
added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug in the Board Editor where the "Clear Board" action would fail or cause an invalid state. The previous implementation attempted to load an empty FEN string, which triggers Position.setupPosition validation. Since a valid chess position requires kings, the empty FEN was rejected, leading to crashes or the board not updating.
Changes
BoardEditorController: Added a dedicated clearBoard() method. This method bypasses FEN parsing and directly updates the state with an empty piece map and reset metadata (castling rights, en passant, etc.).
BoardEditorScreen: Updated the "Clear Board" bottom sheet action to call the new clearBoard() method instead of loadFen(kEmptyFEN).