Refactor online_friends and friend_screen to prevent a hang#3135
Merged
Conversation
veloce
reviewed
May 8, 2026
| }); | ||
|
|
||
| final onlineAndFollowingProvider = | ||
| FutureProvider.autoDispose<(IList<OnlineFriend> onlineFriends, IList<User> following)>(( |
Contributor
There was a problem hiding this comment.
FutureProvider already returns an AsyncValue so we should keep that.
Contributor
There was a problem hiding this comment.
Actually I kept your work but chose to go even further in the simplification and remove the combined provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
online_friends.dart
Change the build to non-blocking by returning an initial empty state and updating it reactively via the socket stream
friend_screen.dart
Remove async/await to use ref.watch(provider) directly