Be sure to properly cancel and dispose the Retro timer#3088
Merged
Conversation
veloce
reviewed
May 2, 2026
| void _refreshCurrentNode({bool recomputeRootView = false}) { | ||
| state = AsyncData( | ||
| state.requireValue.copyWith( | ||
| root: recomputeRootView ? _root.view : state.requireValue.root, |
Contributor
There was a problem hiding this comment.
This change is not relevant in that PR... but ok, it makes sense to have it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Named the timer and made sure we are properly storing it, canceling it, and disposing it.
Changed the second
mistakes.toIList()because it was redundant. It has atoIlist()right above that.