Skip to content

fix errors in tv app link tests#3051

Merged
veloce merged 1 commit into
lichess-org:mainfrom
HaonRekcef:fix-tv-tests
Apr 27, 2026
Merged

fix errors in tv app link tests#3051
veloce merged 1 commit into
lichess-org:mainfrom
HaonRekcef:fix-tv-tests

Conversation

@HaonRekcef

Copy link
Copy Markdown
Collaborator

fixes two errors/warnings that appeared when running the tests locally:

lichess-mobile/test/app_links_service_test.dart: resolveAppLinkUri resolves /@/user/tv link                                                                                                                                                                      
SEVERE: [TvScreen] could not load stream; type 'Null' is not a subtype of type 'Future<ExportedGame>'
#0      MockUserRepository.getCurrentGame (file:///home/noah/Dokumente/lichess/lichess-mobile/test/app_links_service_test.dart:54:7)
#1      TvController._connectWebsocket (package:lichess_mobile/src/model/tv/tv_controller.dart:88:59)
#2      TvController.build (package:lichess_mobile/src/model/tv/tv_controller.dart:61:12)
#3      ElementWithFuture.handleFuture.<anonymous closure> (package:riverpod/src/core/element.dart:206:30)
#4      ElementWithFuture._handleAsync (package:riverpod/src/core/element.dart:270:35)
#5      ElementWithFuture.handleFuture (package:riverpod/src/core/element.dart:200:12)
#6      $AsyncNotifierProviderElement.handleCreate (package:riverpod/src/providers/async_notifier.dart:89:5)
#7      AsyncNotifier.runBuild (package:riverpod/src/providers/async_notifier/orphan.dart:38:22)
#8      $ClassProviderElement.create (package:riverpod/src/core/provider/notifier_provider.dart:560:28)
#9      ProviderElement.buildState (package:riverpod/src/core/element.dart:684:28)
#10     ProviderElement.mount (package:riverpod/src/core/element.dart:537:7)

and

lichess-mobile/test/app_links_service_test.dart: resolveAppLinkUri resolves /@/user/tv link                                                                                                                                                                      
SEVERE: [TvScreen] could not load stream; type 'Null' is not a subtype of type 'Future<ExportedGame>'
#0      MockUserRepository.getCurrentGame (file:///home/noah/Dokumente/lichess/lichess-mobile/test/app_links_service_test.dart:54:7)
#1      TvController._connectWebsocket (package:lichess_mobile/src/model/tv/tv_controller.dart:88:59)
#2      TvController.build (package:lichess_mobile/src/model/tv/tv_controller.dart:61:12)
#3      ElementWithFuture.handleFuture.<anonymous closure> (package:riverpod/src/core/element.dart:206:30)
#4      ElementWithFuture._handleAsync (package:riverpod/src/core/element.dart:270:35)
#5      ElementWithFuture.handleFuture (package:riverpod/src/core/element.dart:200:12)
#6      $AsyncNotifierProviderElement.handleCreate (package:riverpod/src/providers/async_notifier.dart:89:5)
#7      AsyncNotifier.runBuild (package:riverpod/src/providers/async_notifier/orphan.dart:38:22)
#8      $ClassProviderElement.create (package:riverpod/src/core/provider/notifier_provider.dart:560:28)
#9      ProviderElement.buildState (package:riverpod/src/core/element.dart:684:28)
#10     ProviderElement.mount (package:riverpod/src/core/element.dart:537:7)

Note: That the code I added was mostly generated by a LLM.

@veloce veloce merged commit e179852 into lichess-org:main Apr 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants