Add alphabetical sort toggle to puzzle openings screen#3019
Closed
adharshio wants to merge 9 commits into
Closed
Conversation
Co-authored-by: r3econ <[email protected]>
Fixes lichess-org#2981 - Add sort toggle button in app bar (popular ↔ alphabetical) - Sort is done client-side as the server endpoint does not support order param - puzzleOpeningsProvider is now a family provider keyed by sort order - Both orders are cached separately for 1 day
Contributor
Author
|
Closing in favor of #3045 which has a clean commit history |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2981
Here is a video recording showing the result:
sortedOpenings.mp4