Fix kid mode state problem#2930
Merged
veloce merged 1 commit intoApr 9, 2026
Merged
Conversation
…n states When the user taps the kid mode tile, a _pendingKidModeRefresh flag is set. When the app lifecycle transitions back to resumed (user returns from the browser), accountProvider is invalidated and the correct state is fetched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following problem:
Root cause
launchUrlresolves immediately after handing the URL off to the OS — not when the user returns to the app. SoaccountProviderwas being invalidated and re-fetched before the user had a chance to make any changes in the browser, leaving the UI with stale data on return.Fix
Add a
WidgetsBindingObserverto both the drawer and preferences screen states. When the user taps the kid mode tile, a_pendingKidModeRefreshflag is set. When the app lifecycle transitions back to resumed (i.e. the user returns from the browser),accountProvideris invalidated and the correct state is fetched.Demo
Before
kid_mode_bug_before.mov
After
kid_mode_bug.mov