Fix last edited PGN header not saved on share (#2850)#2911
Merged
veloce merged 1 commit intoApr 8, 2026
Conversation
Flush all text controller values into state before generating the PGN. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2850
Summary
?value in the exported PGN. This most commonly affected BlackElo since it's the last rating field.Changes
analysis_share_screen.dart: Iterate through all text controllers and callupdatePgnHeaderfor each before callingmakeExportPgn()analysis_share_screen_test.dart: Verifies that the last edited field (BlackElo, WhiteElo) is correctly persisted when sharing without first unfocusingTest plan
flutter test test/view/analysis/analysis_share_screen_test.dart