Fix the over the board clock switching before promotion piece is selected#2888
Merged
veloce merged 1 commit intoApr 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a pawn reaches the last rank the clock was immediately switching to the opponent before the player chose a promotion piece. Now the clock only switches after the promotion selection is confirmed.
The onMove callback fires as soon as the pawn lands on the last rank before the promotion dialog even shows up just moved the clock switch behind a condition of if the move is a promotion skip switching in onMove and do it in onPromotionSelection instead
Fixes #2819 - "bug in "over the board" mode"