Broadcast Server Analysis Summary#2610
Merged
veloce merged 2 commits intolichess-org:mainfrom Feb 8, 2026
Merged
Conversation
HaonRekcef
force-pushed
the
broadcast-game-summary
branch
3 times, most recently
from
df82b33 to
b6352d2
Compare
- Broadcast Game Summary - Extract ACPL chart and Summary Table into separate widgets - fix lichess-org#1666 - add Broadcast graph tests
HaonRekcef
force-pushed
the
broadcast-game-summary
branch
from
b6352d2 to
3196b86
Compare
HaonRekcef
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds ACPL (Average Centipawn Loss) chart and analysis summary table to Broadcast Games, extracting common analysis visualization logic into reusable widgets. The changes address issue #1666 by migrating from old localization keys (nbInaccuracies, nbMistakes, nbBlunders) to new ones (numberInaccuracies, numberMistakes, numberBlunders) and removing manual capitalization. The PR also fixes a bug where division lines were displayed incorrectly when viewing moves off the mainline.
Changes:
- Extracted ACPL chart and game summary table into reusable widget files (
acpl_chart.dart,game_summary_table.dart) - Added broadcast game summary view with ACPL chart and analysis statistics
- Updated localization key usage to match server API changes (issue #1666)
- Fixed division line rendering to only show current position marker when on mainline
- Added comprehensive test coverage for the new broadcast game summary feature
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
lib/src/widgets/acpl_chart.dart |
New reusable ACPL chart widget extracted from analysis screen |
lib/src/widgets/game_summary_table.dart |
New reusable game summary table widget with player statistics |
lib/src/view/broadcast/broadcast_game_summary.dart |
New broadcast-specific summary view integrating chart and table |
lib/src/view/broadcast/broadcast_game_screen.dart |
Integrated summary tab into broadcast game screen |
lib/src/model/broadcast/broadcast_repository.dart |
Added API support for fetching analysis summary from server headers |
lib/src/model/broadcast/broadcast_analysis_controller.dart |
Added analysis summary state and ACPL chart data generation |
lib/src/model/broadcast/broadcast.dart |
Added type definitions for broadcast analysis summary |
lib/src/view/analysis/server_analysis.dart |
Refactored to use new reusable widgets, removing duplicated code |
lib/src/model/analysis/analysis_controller.dart |
Changed ACPL chart data type from IList<Eval> to IList<ExternalEval> |
test/view/broadcast/broadcast_game_screen_test.dart |
Added test verifying broadcast game summary display |
test/model/broadcast/example_data.dart |
Added test data for analysis summary |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
veloce
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ACPL Graph and the analysis table to the Broadcast Games
Preview:
I extracted the logic of the ACPL chart into
acpl_chart.dartand the table intogame_summary_tableto avoid code duplication.No functional changes to the Lichess game analysis intended.
Additionally:
Tested with the server, now it works)