Fix multiple analysis session issues#2496
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes multiple issues with standalone analysis sessions in the chess analysis feature. The changes address problems where opening a standalone analysis from a puzzle or load position would incorrectly load a previously saved analysis instead of the new position, fail to navigate to the correct path, and display unwanted orange highlighting.
Key changes:
- Added tracking of the current path in saved standalone analysis sessions via
_savedStandalonePath - Modified standalone analysis loading logic to only restore saved state when opening with empty PGN
- Fixed orange box highlighting by setting
pathToLiveMoveto null for standalone analysis sessions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
veloce
left a comment
There was a problem hiding this comment.
Thanks for the fix. Having some tests would be nice here.
added extensive tests |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes: