Backport fixes/features to 0.18.x#2482
Merged
veloce merged 6 commits intolichess-org:v0.18.xfrom Jan 6, 2026
Merged
Conversation
…, firi) and fixing staunty knight to be aligned center) (lichess-org#2380) * Add purple board theme in list (chessground dependency) * Change chessground version to 7.3.0
getAPNSToken() is the only iOS specific thing that happens in this file, so I think there's a high probabillity that the issues are related to that. According to https://firebase.google.com/docs/cloud-messaging/flutter/get-started we need to get permission *before* calling getAPNSToken(). Currently it looks like there could be a race condition where the connectivity change listener fires before we call requestPermission(). Fix this by moving the ref.listen() below the requestPermission() call.
And make sure _registeredDevice flag is only set when device is actually registered.
This is an alternate fix for lichess-org#1232 which does not need the 500ms delay. When entering the analysis board, the delay of 500ms before scrolling to the current move is unexpected for users. With this solution, we can jump to the current move immedialtely.
tom-anders
requested review from
Copilot and
veloce
and removed request for
Copilot
Contributor
|
Out of principle I would not include new features in a hot fix release, even small ones. But ok, let's keep them this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... so that we can create 0.18.3 from this branch while we still have Riverpod 3 problems on
main.The most important commit is the notification fix (that was confirmed to work in 0.19.x), but I also cherry-picked some more fixes/features that seemed low risk and did not cause any non-trivial merge conflicts. Here's an overview: