Skip to content

Comments

fix: remove delay when entering analysis board#2471

Merged
veloce merged 1 commit intolichess-org:mainfrom
tom-anders:betterFixFor1232
Dec 30, 2025
Merged

fix: remove delay when entering analysis board#2471
veloce merged 1 commit intolichess-org:mainfrom
tom-anders:betterFixFor1232

Conversation

@tom-anders
Copy link
Collaborator

This is an alternate fix for #1232 which does not need the 500ms delay.

When entering the analysis board, the delay of 500ms before scrolling to the current move is unexpected for users. With this solution, we can jump to the current move immediately.

Before (note the delay before we scroll to the last move)

before.webm

After (no delay, tab animation still works, so no regression of #1232)

after.webm

@tom-anders tom-anders requested a review from veloce December 30, 2025 11:03
This is an alternate fix for lichess-org#1232 which does not need the 500ms delay.

When entering the analysis board, the delay of 500ms before scrolling to
the current move is unexpected for users. With this solution, we can
jump to the current move immedialtely.
@veloce veloce merged commit c7a4ce3 into lichess-org:main Dec 30, 2025
1 check passed
tom-anders added a commit to tom-anders/lichess-mobile that referenced this pull request Jan 5, 2026
This is an alternate fix for lichess-org#1232 which does not need the 500ms delay.

When entering the analysis board, the delay of 500ms before scrolling to
the current move is unexpected for users. With this solution, we can
jump to the current move immedialtely.
tom-anders added a commit to tom-anders/lichess-mobile that referenced this pull request Jan 6, 2026
This is an alternate fix for lichess-org#1232 which does not need the 500ms delay.

When entering the analysis board, the delay of 500ms before scrolling to
the current move is unexpected for users. With this solution, we can
jump to the current move immedialtely.
tom-anders added a commit to tom-anders/lichess-mobile that referenced this pull request Jan 6, 2026
This is an alternate fix for lichess-org#1232 which does not need the 500ms delay.

When entering the analysis board, the delay of 500ms before scrolling to
the current move is unexpected for users. With this solution, we can
jump to the current move immedialtely.
veloce added a commit that referenced this pull request Jan 6, 2026
* feat: update chessground to 7.3.0 (add a board (purple), pieces (xkcd, firi) and fixing staunty knight to be aligned center) (#2380)

* Add purple board theme in list (chessground dependency)

* Change chessground version to 7.3.0

* feat(otb): add takeback button (#1642) (#2334)

* potential fix for notification issues on iOS (#2451)

getAPNSToken() is the only iOS specific thing that happens in this file,
so I think there's a high probabillity that the issues are related to
that.

According to
https://firebase.google.com/docs/cloud-messaging/flutter/get-started we
need to get permission *before* calling getAPNSToken(). Currently it
looks like there could be a race condition where the connectivity change
listener fires before we call requestPermission(). Fix this by moving
the ref.listen() below the requestPermission() call.

* Fix register firebase after sign in

And make sure _registeredDevice flag is only set when device is actually
registered.

* fix: remove delay when entering analysis board (#2471)

This is an alternate fix for #1232 which does not need the 500ms delay.

When entering the analysis board, the delay of 500ms before scrolling to
the current move is unexpected for users. With this solution, we can
jump to the current move immedialtely.

* feat: add log screen (#2463)

---------

Co-authored-by: lumiknit <[email protected]>
Co-authored-by: overcharged <[email protected]>
Co-authored-by: Vincent Velociter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants