fix: false positive for alternative castling notation in puzzles#2355
Merged
veloce merged 5 commits intolichess-org:mainfrom Nov 11, 2025
Merged
fix: false positive for alternative castling notation in puzzles#2355veloce merged 5 commits intolichess-org:mainfrom
veloce merged 5 commits intolichess-org:mainfrom
Conversation
Check should be always at the end, so this is a tiny performance improvement
Collaborator
Author
|
This also fixes a (very rare) bug in study and analysis board where alt castling notation would not be correctly applied for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plus some refactoring for
SanMoveFixes #2354