Made it so that Wakelock disables when a game ends - DC#2275
Merged
veloce merged 3 commits intolichess-org:mainfrom Nov 11, 2025
Merged
Made it so that Wakelock disables when a game ends - DC#2275veloce merged 3 commits intolichess-org:mainfrom
veloce merged 3 commits intolichess-org:mainfrom
Conversation
veloce
reviewed
Oct 31, 2025
lib/src/view/game/game_body.dart
Outdated
| debugPrint('SEVERE: [GameBody] could not load game data; $e\n$s'); | ||
| return const LoadGameError('Sorry, we could not load the game. Please try again later.'); | ||
| case AsyncData(value: final gameState, isRefreshing: false): | ||
| if (gameState.game.status != GameStatus.created && |
Contributor
There was a problem hiding this comment.
Would be better in the _stateListener I think, instead of making a side effect in the build method.
| }); | ||
| }); | ||
|
|
||
| group('Wakelock', () { |
ChopinDavid
force-pushed
the
Issue2271
branch
from
4416d26 to
fe12cf4
Compare
Contributor
Author
|
@veloce went ahead and made that change and rebased upstream/main. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would close #2271.
Please, let me know if there are other places I should have added this and I'll be sure to make updates.