feat: learn from your mistakes by tom-anders · Pull Request #2229 · lichess-org/mobile

tom-anders · 2025-09-27T10:26:13Z

retro_final.webm

Copilot

Pull Request Overview

This PR introduces a retrospective analysis feature called "Learn from your mistakes" that helps players review and practice the critical mistakes they made in their games. The feature identifies significant mistakes from server analysis and creates an interactive training environment where users can attempt to find better moves.

Key changes:

Added a comprehensive retro analysis system with mistake detection and interactive training
Extracted reusable UI components from puzzle widgets for broader use
Enhanced the analysis board system to support different interaction modes

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
test/view/analysis/retro_screen_test.dart	Comprehensive test suite for the retro screen functionality
test/example_data.dart	Made `makeSteps` function public for reuse in tests
lib/src/view/puzzle/puzzle_feedback_widget.dart	Extracted reusable components and made `FeedbackTile` public
lib/src/view/analysis/server_analysis.dart	Added "Learn from your mistakes" button to server analysis summary
lib/src/view/analysis/retro_settings_screen.dart	Settings screen for retro analysis preferences
lib/src/view/analysis/retro_screen.dart	Main retro analysis screen with interactive mistake review
lib/src/view/analysis/analysis_board.dart	Enhanced base analysis board to support retro mode interactions
lib/src/model/explorer/opening_explorer_repository.dart	Added Riverpod provider for opening explorer repository
lib/src/model/common/eval.dart	Added utility method for calculating winning chances differences
lib/src/model/analysis/retro_controller.dart	Core controller logic for retro analysis functionality

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

lib/src/view/analysis/retro_settings_screen.dart

test/view/analysis/retro_screen_test.dart

veloce · 2025-09-28T21:39:24Z

the screen recording just shows a static screen @tom-anders , perhaps wrong one?

tom-anders · 2025-09-29T04:42:40Z

Oh that may be related to my recent emulator problems, I'll make a new one today

veloce

I realise this is a lot of work, so thank you very much for this!

It looks very good, I have only small comments that should be easy to fix.

lib/src/model/analysis/retro_controller.dart

lib/src/view/analysis/server_analysis.dart

lib/src/view/puzzle/puzzle_feedback_widget.dart

test/view/analysis/retro_screen_test.dart

lib/src/view/analysis/retro_screen.dart

veloce · 2025-09-29T20:10:09Z

To improve the discoverability of the feature, I'd suggest to add a "Learn from your mistakes" button on game screen if the server analysis is available. What do you think? The button could be added in the game screen end pop-up, and game menu.

tom-anders · 2025-09-29T22:28:04Z

Thanks for the review!

To improve the discoverability of the feature, I'd suggest to add a "Learn from your mistakes" button on game screen if the server analysis is available. What do you think? The button could be added in the game screen end pop-up, and game menu.

Good idea! Maybe directly after the game, we could also add a "learn from mistakes" button to the menu that would request server analysis, display some kind of progress dialog, and then take you directly to the retro screen...?
IIRC we used to have a "request analysis" button there, but it was removed at some point...?

tom-anders · 2025-09-29T23:20:08Z

Think I addressed all the comments now. Also added a new video that hopefully works this time

veloce · 2025-09-30T00:09:35Z

Good idea! Maybe directly after the game, we could also add a "learn from mistakes" button to the menu that would request server analysis, display some kind of progress dialog, and then take you directly to the retro screen...?

yes we could do that; this adds complexity and will likely not work from time to time, but not a big deal.

if we do that though, I'd handle the logic in the retro controller:

if the game was not analysed yet, request server analysis in retro build method
while server analysis is pending, simply display a circular progress with the text "Calculating moves..."
probably need a timeout like 1 minute, if for some reason the server analysis never finishes

veloce · 2025-09-30T00:15:00Z

lib/src/model/analysis/retro_controller.dart

+          return null;
+        }
+
+        // https://github.com/lichess-org/lila/blob/d29f27d8cbb0e0dac38308c23c63b828028c085f/ui/analyse/src/nodeFinder.ts#L26


This is nitpicking again, but it is better to make a constant of the 0.1 here. So you can name it for better clarity and put the ref to lila code here.

Also better just put the file where the logic is found, without the line number; lines number will most likely change.

As I understand it, since I used the "Copy permalink" button, these links refer to a specific commit, not to the master branch. So they will always point to the same line/code

lib/src/model/analysis/retro_controller.dart

veloce · 2025-09-30T00:25:00Z

lib/src/model/analysis/retro_controller.dart

+
+/// Depth needed to evaluate alternative solution moves.
+///
+/// https://github.com/lichess-org/lila/blob/d29f27d8cbb0e0dac38308c23c63b828028c085f/ui/analyse/src/retrospect/retroCtrl.ts#L151


Better not put the link to Lila code actually; line number will most probably change; or just put the link to the whole rectroCtrl file.

tom-anders · 2025-09-30T17:10:14Z

Good idea! Maybe directly after the game, we could also add a "learn from mistakes" button to the menu that would request server analysis, display some kind of progress dialog, and then take you directly to the retro screen...?

yes we could do that; this adds complexity and will likely not work from time to time, but not a big deal.

if we do that though, I'd handle the logic in the retro controller:
* if the game was not analysed yet, request server analysis in retro `build` method

* while server analysis is pending, simply display a circular progress with the text "Calculating moves..."

* probably need a timeout like 1 minute, if for some reason the server analysis never finishes

Sounds good, I moved it to a new issue

lib/src/model/engine/evaluation_mixin.dart

veloce · 2025-09-30T23:51:38Z

test/view/analysis/retro_screen_test.dart

-          OpeningExplorerEntry.empty(),
-    ),
-  );
+  final mockClient = MockClient((request) {


lib/src/model/engine/evaluation_preferences.dart

veloce · 2025-10-01T22:24:24Z

rebasing your changes now with main @tom-anders

…red search time)

tom-anders force-pushed the learn-from-mistakes branch 2 times, most recently from 1c01a7a to 7561575 Compare September 27, 2025 10:31

tom-anders marked this pull request as ready for review September 27, 2025 10:46

tom-anders requested review from Copilot and veloce September 27, 2025 10:46

Copilot AI reviewed Sep 27, 2025

View reviewed changes

lib/src/view/analysis/retro_settings_screen.dart Show resolved Hide resolved

test/view/analysis/retro_screen_test.dart Show resolved Hide resolved

veloce reviewed Sep 29, 2025

View reviewed changes

lib/src/view/analysis/retro_screen.dart Outdated Show resolved Hide resolved

tom-anders force-pushed the learn-from-mistakes branch from 9b6e35d to 8718496 Compare September 29, 2025 22:40

veloce reviewed Sep 30, 2025

View reviewed changes

tom-anders mentioned this pull request Sep 30, 2025

Add "Learn from you mistakes" button to post-game dialog #2237

Closed

tom-anders force-pushed the learn-from-mistakes branch from 86d4cc7 to 1ffa130 Compare September 30, 2025 19:07

veloce reviewed Sep 30, 2025

View reviewed changes

tom-anders added 8 commits October 1, 2025 18:24

feat: learn from your mistakes

92b7ab8

various fixes from code review

5246302

add "learn from mistakes" button to game result dialog

f47bef5

test: mock http instead of repositories

39397c9

address more review comments

9a91247

fix test

d4c44a0

fix stopEval()

93a9880

only restart eval if the move was correct (to go back to user-configu…

271df7e

…red search time)

veloce force-pushed the learn-from-mistakes branch from 82e35fd to 271df7e Compare October 1, 2025 22:24

veloce merged commit 271df7e into lichess-org:main Oct 1, 2025
1 check passed

veloce mentioned this pull request Dec 27, 2025

Learn from your mistakes feature #488

Closed

Uh oh!

Comments

Conversation

tom-anders commented Sep 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

veloce commented Sep 28, 2025

Uh oh!

tom-anders commented Sep 29, 2025

Uh oh!

veloce left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

veloce commented Sep 29, 2025

Uh oh!

tom-anders commented Sep 29, 2025

Uh oh!

tom-anders commented Sep 29, 2025

Uh oh!

veloce commented Sep 30, 2025

Uh oh!

veloce Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

veloce Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

tom-anders Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

veloce Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

tom-anders commented Sep 30, 2025

Uh oh!

Uh oh!

veloce Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

veloce commented Oct 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tom-anders commented Sep 27, 2025 •

edited

Loading