fix: reset scroll when navigating study chapters#2164
Merged
veloce merged 1 commit intolichess-org:mainfrom Sep 7, 2025
Merged
fix: reset scroll when navigating study chapters#2164veloce merged 1 commit intolichess-org:mainfrom
veloce merged 1 commit intolichess-org:mainfrom
Conversation
Contributor
|
Hi! Not sure to understand the problem here; can you post a before/after screen recording please? |
Contributor
Author
|
Before the change, when moving to the second page, I have to manually scroll upwards, since the scroll position doesn't reset. before.mp4After the change, this is automatic when any content is changed. after.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scroll position in the study comment persists even after the text is changed.
This results in behaviour that results in the user having to manually scroll to the top of the comment if they want to read the text.
This PR resets the scroll position when the widget changes, to save the user having to manually scroll.