unix: remove code for unsupported os x versions #758
Conversation
|
Even though 10.7 is not officially supported, I'd still classify this as a breaking change. |
|
@cjihrig Ok, I get that. |
|
Please do leave 10.7 support, dropping 10.6 is ok since we haven't supported it for a while. /cc @libuv/collaborators |
|
Counterargument: Apple doesn't support 10.7 anymore either, the last update was three years ago. Counter-counterargument: if libuv still works on 10.7, I don't see a good reason to drop support. |
|
Relevant or no, I believe the lowest supported version of os x for nodejs is 10.7. |
|
This code does not seem to be really complex or big, I don't see any point in removing it right now. There is technically no maintenance costs involved. |
|
Hum. #753 would break on 10.6, so we either add more ifdefs to support defunkt versions or we remove them as this patch does. I'm +1 with this change because we can't really claim to support 10.6: we don't test on it, and we are just about to break it. |
|
@kthelgason disregard my first comment, my brain parsed ifed / ifndef wrong :-P |
|
Just to clarify, the code being removed is for 10.6 and older, so 10.7 support is unchanged. The name of the branch is pretty confusing :) As @indutny points out, there is no great maintenance benefit here, on the other hand, fewer |
|
So, @libuv/collaborators shall we vote? +1. |
|
+1 to removing it, but in a semver-major bump. |
|
+0, no strong opinion.
By that logic, we should drop support for 10.7 as well because we don't test that version either. (At least, I don't, but I do test 10.8.) |
|
+1, drop 10.6 in the next breaking release. |
|
-1 |
|
Ok, labeling this one as v2 then. |
Ref: nodejs/build#367 libuv is going to drop 10.6 in v2. Ref: libuv/libuv#758 OS X versions below 10.9 are not supported by Apple anymore and do not receive security patches. PR-URL: nodejs#6402 Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Refs: nodejs/build#367 libuv is going to drop 10.6 in v2. Ref: libuv/libuv#758 OS X versions below 10.9 are not supported by Apple anymore and do not receive security patches. PR-URL: #6402 Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Refs: nodejs/build#367 libuv is going to drop 10.6 in v2. Ref: libuv/libuv#758 OS X versions below 10.9 are not supported by Apple anymore and do not receive security patches. PR-URL: #6402 Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Myles Borins <[email protected]>
|
Ooops, I had forgotten about this and made it myself as part of the "old platforms cleanup" here: #966 Sorry about that! |
|
no worries! deleting my branch then |
7 participants
@saghul mentioned in #753 that versions of OS X older than 10.7 are no longer supported.
This PR removes code that is specific to those versions.